search

kedro-org / kedro-starters

Templates for your Kedro projects.
Apache License 2.0
63 stars 57 forks source link

Pin Pip and fix lint e2e tests #201

Closed noklam closed 6 months ago

noklam commented 6 months ago

Motivation and Context

  1. Lint doesn't require project requirements anymore since we moved to ruff and not using kedro lint
  2. Pin pip <=23.2, see https://github.com/kedro-org/kedro/blame/b11666e33fce76e724d15922a786a6ce9fd4e791/features/environment.py#L107

Noted pip version is set twice. Previously pip version are sometimes in 23.3 or 21 depending on the OS/tests combo.

  1. During e2e test, a new virtualenv is created, so pip is pin.
  2. during e2e test before installing the test requirements, pip is also fix.

    How has this been tested?

Checklist

astrojuanlu commented 6 months ago

Merging anyway, we can address the comments later