Closed astrojuanlu closed 1 year ago
Closed as this isn't an issue we need to solve.
For the record, I confirm that on my macOS Ventura I managed to get a working build installing nodejs
, cairo
and pango
with brew
.
With @rashidakanchwala we found some issues in the Makefile
, I'll open a separate issue for that.
About my original problem though, I'll try to create a reproducer because I'm worried there's some weird condition with the conda provided nodejs.
Reported this issue upstream: https://github.com/conda-forge/nodejs-feedstock/issues/296
I think the root cause of this issue is the fact that macOS does not use OpenSSL, but LibreSSL:
> openssl version
LibreSSL 3.3.6
and therefore it's probably not affected by the security issue that was patched in NodeJS 17 onwards. I couldn't find a reference to this, but I'm 90 % certain.
In fact, by downgrading OpenSSL to < 3
inside my micromamba environment, I was able to go ahead. Or, alternatively, export NODE_OPTIONS=--openssl-legacy-provider
, as suggested all around https://github.com/webpack/webpack/issues/14532.
(To clarify, I knew this workaround all along, but the point of the debugging was to understand why the exact same Node version installed in two different ways was giving different results).
From what I'm reading online, it looks like other people were able to fix the issue by upgrading to react-scripts
5, which pins a version of webpack that contains a fix for this OpenSSL problem (https://stackoverflow.com/a/71334532/554319, https://github.com/webpack/webpack/pull/14584).
So I guess the actual issue is: the react-scripts
version locked for Kedro-Viz requires an insecure SSL setting on systems based on OpenSSL.
My original use case is solved because I found a workaround, but I think the issue stands, even if it mostly affects developers/contributors on Linux or using conda (nobody from the current core team). I'm renaming it for clarity, reopening it, and leaving it for your consideration @tynandebold.
Thank you for such a deep investigation.
We're in the process of upgrading React dependencies, with react-scripts being on the list. This should be fixed when that's done.
I'm going to close it again now, given that I haven't ever heard of this being an issue for anyone else in 1.5 years of working on Viz.
Tried this again with #1848, it now works.
Description
As per title.
Context
I was trying to add a conda-forge recipe for kedro-viz at https://github.com/conda-forge/staged-recipes/pull/22142 Please bear in mind that I'm not a Node.js expert, so I'm trying to follow a mix of https://github.com/kedro-org/kedro-viz/blob/main/CONTRIBUTING.md#development-guidelines and what the CI does.
I'm even trying to install the same version that CI uses, to no avail:
https://github.com/kedro-org/kedro-viz/blob/25c55c24f69e0a6c4c744a3ff2559ebb60dd5d86/.circleci/continue_config.yml#L45-L48
Steps to Reproduce
npm install
npm run build
Expected Result
Build succeeds.
Actual Result
I tried
npm audit fix --force
as suggested in https://stackoverflow.com/a/73027407, but got a different error message:Your Environment
Include as many relevant details as possible about the environment you experienced the bug in:
Checklist