Refactor Shareableviz REST endpoint - Githubissues

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

662 stars 110 forks source link

Refactor Shareableviz REST endpoint #1739

Closed ravi-kumar-pilla closed 6 months ago

ravi-kumar-pilla commented 6 months ago

Description

Split PR for https://github.com/kedro-org/kedro-viz/pull/1708

Development notes

Updated DeployerConfiguration class to have platform, endpoint, bucket_name as properties
Updated /deploy REST API route to accept new DeployerConfiguration inputs
Renamed S3Deployer to AWSDeployer to be consistent with cloud providers
Refactored deployer classes to accept new input parameters and removed deploy_and_get_url method as we take endpoint (hosted url) as an input
Updated pytests

NOTE: Added # pylint: skip-file for /launchers/cli.py as this PR does not include cli changes for ease of review.

QA notes

All pytests should pass

Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes