Refactor Shareableviz CLI - Githubissues

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

662 stars 110 forks source link

Refactor Shareableviz CLI #1740

Closed ravi-kumar-pilla closed 6 months ago

ravi-kumar-pilla commented 6 months ago

Description

Split PR for https://github.com/kedro-org/kedro-viz/pull/1708

Development notes

Updated CLI command kedro viz deploy to accept the following options - [--platform, --endpoint, --bucket-name] for shareableviz and introduced a time limit of 5min
Refactored CLI launcher click.echo statements by creating helper function
Updated pytests

NOTE: Please review it after #1739

QA notes

All pytests should pass

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

ravi-kumar-pilla commented 6 months ago

I left some small comments, but generally this looks good 👍 Should any of the changes introduced in this PR or #1739 be added to the release notes?

Thank you @merelcht . All these PRs are mostly internal changes and the outcome is to extend support for Azure, GCP. I will add this in the release note once these PRs are merged to feature/shareableviz-extended-support