search

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.
https://demo.kedro.org
Apache License 2.0
662 stars 110 forks source link

Make `kedro viz run --pipeline` consistent with `kedro run --pipeline` #1754

Open astrojuanlu opened 6 months ago

astrojuanlu commented 6 months ago

I think kedro viz run --pipeline should be consistent with how kedro run --pipeline behaves. This behavior was surprising also for me.

Originally posted by @astrojuanlu in https://github.com/kedro-org/kedro-viz/issues/1733#issuecomment-1936293108

astrojuanlu commented 6 months ago

More context in the linked issue. Essentially, spaces are valid for pipeline names in Kedro Viz, but not for Kedro Framework. So kedro run --pipeline="Reporting stage" would not work, but kedro viz run --pipeline="Reporting stage" does.

I liberally opened this on Kedro Viz, seemingly implying that Viz should converge with Framework. But maybe it should be the other way around? (:

rashidakanchwala commented 5 months ago

@astrojuanlu - do we need to do work on Kedro-Viz, or will this be a Kedro framework ticket then?

astrojuanlu commented 5 months ago

It's for us to decide what to do cc @merelcht

merelcht commented 5 months ago

We'll need to have a look at what consistency between the CLI on Framework and Viz means. Is this the only command with inconsistency? And how do other similar arguments get treated on the Framework side? Maybe changing this to be consistent with Viz would mean breaking consistency with how things are done across the CLI on Framework.