Fixes for all Bugbash 8.0.0 findings

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

650 stars 107 forks source link

Fixes for all Bugbash 8.0.0 findings #1767

Closed ravi-kumar-pilla closed 4 months ago

ravi-kumar-pilla commented 4 months ago

Description

As per title

Development notes

Fixed Preview row length display
Important doc note added under experiment tracking doc. Starting from version 8.0.0 of Kedro-Viz, Experiment Tracking is exclusively supported for users with kedro-datasets version 2.1 or higher.
Added banner in Experiment Tracking to let users know of bumping kedro-datasets to >= 2.1.0
Fixed a bug on kedro viz deploy command when bucket is not available in case of Azure

QA notes

Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

jitu5 commented 4 months ago

Important doc note added under experiment tracking doc. Starting from version 8.0.0 of Kedro-Viz, Experiment Tracking is exclusively supported for users with kedro-datasets version 2.1 or higher.

ravi-kumar-pilla commented 4 months ago

Hi @stephkaiser,

Since there is a breaking change with kedro-datasets 2.1.0 for Kedro-Viz, we are showing the below banner for experiment-tracking on all the panels (Overview, Metrics, Plots) from Kedro-Viz versions 8.0.0 and above if the user has kedro-datasets version < 2.1.0. Please let us know if the banner looks fine from design perspective. Thank you

cc: @jitu5 thanks for the banner !

rashidakanchwala commented 4 months ago

Hi @stephkaiser,

Since there is a breaking change with kedro-datasets 2.1.0 for Kedro-Viz, we are showing the below banner for experiment-tracking on all the panels (Overview, Metrics, Plots) from Kedro-Viz versions 8.0.0 and above if the user has kedro-datasets version < 2.1.0. Please let us know if the banner looks fine from design perspective. Thank you

cc: @jitu5 thanks for the banner !

Not sure, if it needs to be yellow, but I will let Steph comment. Can it say kedro-datasets = 2.1.0

jitu5 commented 4 months ago

Not sure, if it needs to be yellow, but I will let Steph comment. Can it say kedro-datasets = 2.1.0

@rashidakanchwala Updated kedro-datasets version number to 2.1.0 in banner and important docs note.

stephkaiser commented 4 months ago

hey team! thanks for flagging this to me. Some minor comments from me:

instead of the yellow can we follow the hover background colour used in the kedro version in the top right corner? but please keep the colour persistent for this text so it's always shown, not only when user hovers over the text. See below screenshots of what i mean for light and dark mode.
Can we also improve the text to make it slightly more helpful for users, maybe something like:

"Kedro-Viz Experiment Tracking is only supported with kedro-datasets version 2.1.0 and above. Please update kedro-datasets in order to use this feature."
the placement of the banner text looks good too, could you share a full screenshot so I can check spacing/padding?

let me know if you guys have any further thoughts or questions, thanks!

jitu5 commented 4 months ago

hey team! thanks for flagging this to me. Some minor comments from me:

instead of the yellow can we follow the hover background colour used in the kedro version in the top right corner? but please keep the colour persistent for this text so it's always shown, not only when user hovers over the text. See below screenshots of what i mean for light and dark mode.

Can we also improve the text to make it slightly more helpful for users, maybe something like:

"Kedro-Viz Experiment Tracking is only supported with kedro-datasets version 2.1.0 and above. Please update kedro-datasets in order to use this feature."

the placement of the banner text looks good too, could you share a full screenshot so I can check spacing/padding?

let me know if you guys have any further thoughts or questions, thanks!

@stephkaiser

jitu5 commented 4 months ago

@stephkaiser Please review and let me know if it needs any more changes.

stephkaiser commented 4 months ago

Thank you @jitu5 the padding/spacing of the banner text looks good to me!

I just noticed the font size is slightly bigger, can we make sure its the same font size as the text below and the Overview/Metrics/Plots tab labels?

jitu5 commented 4 months ago

@stephkaiser Thanks. Banner text font size matched with Overview/Metrics/Plots tab labels.