Make `kedro viz` also do what `kedro viz run` does

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

650 stars 107 forks source link

Make `kedro viz` also do what `kedro viz run` does #1790

Closed deepyaman closed 4 months ago

deepyaman commented 4 months ago

Description

Closes #1789

Development notes

QA notes

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[x] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

ravi-kumar-pilla commented 4 months ago

Hi @deepyaman , Thanks for this. This looks awesome !

[Nit] I understand from the docs that --help will now show (*) infront of the default command. I am wondering if this confuses someone who does not have clear understanding of what this means. Should we implement a class which lists the commands ?

deepyaman commented 4 months ago

Hi @deepyaman , Thanks for this. This looks awesome !

[Nit] I understand from the docs that --help will now show (*) infront of the default command. I am wondering if this confuses someone who does not have clear understanding of what this means. Should we implement a class which lists the commands ?

I noticed that. I think it's very likely it could be a non-issue, in which case I don't think it needs to be over engineered.

If we want to remove the mark, or use something more explicit like (default) instead of *, we could extend DefaultGroup to handle a default_cmd_mark parameter, which would get passed to https://github.com/click-contrib/click-default-group/blob/main/click_default_group.py#L100.

deepyaman commented 4 months ago

If we want to remove the mark, or use something more explicit like (default) instead of *, we could extend DefaultGroup to handle a default_cmd_mark parameter, which would get passed to https://github.com/click-contrib/click-default-group/blob/main/click_default_group.py#L100.

Merged, but just let me know if want to do this; happy to slot it in quickly!

ravi-kumar-pilla commented 4 months ago

If we want to remove the mark, or use something more explicit like (default) instead of *, we could extend DefaultGroup to handle a default_cmd_mark parameter, which would get passed to https://github.com/click-contrib/click-default-group/blob/main/click_default_group.py#L100.

Merged, but just let me know if want to do this; happy to slot it in quickly!

I don't see as a blocker for now. If it is a quick fix, we can say (default) which is much clearer. But I am happy to hear from @rashidakanchwala . Thank you