kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.
https://demo.kedro.org
Apache License 2.0
672 stars 110 forks source link

Fix CircleCI build failure due to secret scan and missing toposort dependency #1819

Closed ravi-kumar-pilla closed 6 months ago

ravi-kumar-pilla commented 6 months ago

Description

Development notes

QA notes

Checklist

astrojuanlu commented 6 months ago

I see there's an actual dependency on toposort

https://github.com/kedro-org/kedro-viz/blob/6206e436029f457386adea67bc2af99b194ae557/package/kedro_viz/services/layers.py#L6

ravi-kumar-pilla commented 6 months ago

I see there's an actual dependency on toposort

https://github.com/kedro-org/kedro-viz/blob/6206e436029f457386adea67bc2af99b194ae557/package/kedro_viz/services/layers.py#L6

yes @astrojuanlu . I think we were using this dependency from Kedro environment. Now that Kedro has dropped it, I added the requirement to our requirements file and will create a ticket to see if we can migrate to graphlib completely. Thanks

astrojuanlu commented 6 months ago

Don't block this one on my review, I'll be in meetings all day 😅