search

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.
https://demo.kedro.org
Apache License 2.0
672 stars 110 forks source link

Drop toposort and migrate to graphlib #1820

Closed ravi-kumar-pilla closed 3 months ago

ravi-kumar-pilla commented 6 months ago

Description

This ticket aims at dropping toposort dependency in favor of built-in graphlib if possible. Following how Kedro team did this - https://github.com/kedro-org/kedro/pull/3728

Context

We were depending on Kedro's environment for toposort dependency and since Kedro dropped this dependency, Viz started failing. This also raises an issue of having transitive dependencies. We can improve the code base to remove such transitive dependencies in future - #1821

Possible Implementation

We use from toposort import CircularDependencyError, toposort_flatten in our layers module. We need to find an alternate implementation to toposort_flatten within graphlib to resolve this issue

Possible Alternatives

Checklist

SajidAlamQB commented 3 months ago

Completed in: https://github.com/kedro-org/kedro-viz/pull/1942