Fix posix path conversion on Windows in DatasetStatsHook - Githubissues

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

647 stars 106 forks source link

Fix posix path conversion on Windows in DatasetStatsHook #1843

Closed ravi-kumar-pilla closed 3 months ago

ravi-kumar-pilla commented 3 months ago

Description

Resolves #1797

Development notes

Passing PurePath to the get_filepath_str function instead of str filepath which complains on Windows
Addressed warnings of deprecation in demo-project

file_path = get_filepath_str(Path(dataset._filepath), dataset._protocol)

QA notes

All tests should pass
When running on a windows machine, there should not be any warning message as shown here -

WARNING  Unable to get file size for the dataset SQLQueryDataset(execution_options={}, filepath=C:/path/to/data/00_scripts/dim_postal_code.sql, load_args={}, sql=None): 'str' object has no attribute 'as_posix'

Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[x] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

ravi-kumar-pilla commented 3 months ago

Declining review requests of small engineering PRs for my own sanity 🙏🏽 If you need extra reviews kindly ask the framework team.

Sure, I added as you were present in the initial discussion. But, I will make sure you are not included on small engineering PRs. Thank you 👍