Closed ravi-kumar-pilla closed 2 months ago
also looping in @merelcht , does it make sense to fix this issue on kedro-datasets side? are we strict on return type validation for file_path? pls let us know.
also looping in @merelcht , does it make sense to fix this issue on kedro-datasets side? are we strict on return type validation for file_path? pls let us know.
Had a discussion on slack and Nok mentioned that filepath is not a well defined API, means there may be entries of datasets which do not have filepath. Though I still think if there is filepath, the type should be consistent. From Viz perspective, we can have the conversion to be foolproof.
Thank you
Description
Testing windows build failure due to StatsHook on main branch.
NOTE: While I tested on windows machine locally, it was working fine. However on CircleCI, filepath has
C:/
, but the system is trying to findC:
(missing the forward slash). After looking into plugins kedro-datasets further, some dataset._filepath returns PurePosixPath while some return string. The fix for https://github.com/kedro-org/kedro-viz/issues/1797 should be made on the datasets side to be consistent.Development notes
The pandas CSV, Excel, Feather, Generic, HDF, json, Parquet, xml has a code block -
while others like deltatable, gbq, sql keep filepath as
str
. I am not completely aware of the reason for this difference. @SajidAlamQB please add if you have any information on this.If this is not intentional, we should be fixing the issue on kedro-datasets.
NOTE:
continue_config.yml
changes are for testing windows build and they will be discarded before merging to mainQA notes
Checklist
RELEASE.md
file