Closed jitu5 closed 1 month ago
overall looks fine to me! Ready for review?
Yes!
Hi @jitu5 , I have left few comments, but most of the code looks great. I feel the migration work is neat and very well organized. Awesome work !! Thank you
The demo link does not have experiment tracking, but our demo site should have ET. Apart from this, PR LGTM. Awesome work @jitu5 !! Thank you
@ravi-kumar-pilla Yes, we treat it as local and show experiment tracking for the following hosts: 'localhost'
, '127.0.0.1'
, and 'demo.kedro.org'
.
Description
Resolves https://github.com/kedro-org/kedro-viz/issues/1785
Development notes
The migration from CircleCI to GitHub Actions will have to be done in parts. This PR addresses the Release part, and the test part was already merged.
Workflows:
deploy-demo.yml
:check-release.yml
:check-version
checks if the version specified on the kedroviz/__init_\.py file is on PyPI already or not. If it isn't, that means a release should be triggered.test-kedro-viz
runs the test suite with all-checks.ymlprepare-release
, extracts release notes from RELEASE.md(using tools/github_actions/extract_release_notes.py) and creates a GitHub release.release.yml
:release_to_npm
checks out the code, sets up Node.js, installs Node dependencies, builds the React application, and then publishes the package to npm.release_to_pypi
checks out the code, sets up tests, makes a Python package, installs twine, and then publishes the package to PyPI.Miro board link
Notes
check-release -> tests (lint, unit, e2e, js-lint-test) -> tags the release -> releases
I successfully ran all the workflow in private repo. For reference: For PyPi https://github.com/jitu5/kedro-viz/actions/runs/8816265319/job/24200003147 https://test.pypi.org/project/kedro-vizzz/9.0.0/
For npm https://github.com/jitu5/kedro-viz/actions/runs/8816265319/job/24200002881 https://www.npmjs.com/package/kedro-vizzz
For deploy demo https://github.com/jitu5/kedro-viz/actions/runs/8805821140/job/24169247490
https://jitu5-kedro-viz.puqtrjp4c6474.eu-west-2.cs.amazonlightsail.com/
QA notes
Checklist
RELEASE.md
file