Inherit tags from nodes for modular pipelines

jitu5 commented 2 months ago

Description

Related to #1822

Incase of expandModularPipelines = false and the filtered nodes happened to be inside a modular pipeline, it should show the modular pipeline node (collapsed view) which seems to be missing on refresh. This PR aims to resolve this issue.

Development notes

https://github.com/kedro-org/kedro-viz/assets/38945204/a336b39c-1d04-471c-a921-89b8a48587ce

QA notes

Added tests to cover changes.

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

rashidakanchwala commented 2 months ago

Did a slightly different approach here https://github.com/kedro-org/kedro-viz/compare/main...inherit-tags .let me know what you think

ravi-kumar-pilla commented 2 months ago

Did a slightly different approach here main...inherit-tags .let me know what you think

I think this updates the tags at the same time we add inputs/outputs to the immediate parent. We are anyway updating the grandparents here - expanded_tree[parent_id].tags.update(modular_pipeline_node.tags). Looks good to me. Thank you

kedro-org / kedro-viz