Following, https://github.com/kedro-org/kedro-viz/pull/1858, the expandAllPipelines flag from config.js was removed which is causing an undefined value, as it is no longer has a default value. This flag was previously used to control the state of expanding all modular pipelines on the initial load of the application in the settings-modal.js.
The code within settings-modal.js uses the getFlagsState function to pull flag data, which included expandAllPipelines. The assumption was that removing it from config.js would suffice for this UI adjustment. However, this led to the flag being undefined elsewhere in the application.
We need to think about how the expandAllPipelines flag should be removed from just from the settings modal.
Suggestions:
We reintroduce the expandAllPipelines flag into config.js and change settings-modal to not include.
implement a new way to initialise this flag across viz, maybe outside of config.js?
Steps to Reproduce
Load the application and see that the flag's value is undefined.
Description
See slack thread: https://kedro-org.slack.com/archives/C04EHA3K7C2/p1714426656093459
Following, https://github.com/kedro-org/kedro-viz/pull/1858, the
expandAllPipelinesflag fromconfig.jswas removed which is causing an undefined value, as it is no longer has a default value. This flag was previously used to control the state of expanding all modular pipelines on the initial load of the application in thesettings-modal.js.The code within settings-modal.js uses the
getFlagsStatefunction to pull flag data, which includedexpandAllPipelines. The assumption was that removing it fromconfig.jswould suffice for this UI adjustment. However, this led to the flag being undefined elsewhere in the application.We need to think about how the
expandAllPipelinesflag should be removed from just from the settings modal.Suggestions:
expandAllPipelinesflag intoconfig.jsand change settings-modal to not include.Steps to Reproduce
Load the application and see that the flag's value is undefined.
Expected Result
expandAllPipelinesshould have a default value.Actual Result
expandAllPipelinesis undefined.