Closed jitu5 closed 1 month ago
There's also this ticket here #1705 , we can add this to next sprint.
One thought is perhaps to name the new boolean after the new --include-preview
flag, so it's clear those two are connected?
@rashidakanchwala Sure I will create a separate PR for change of is_preview_disabled
to is_preview_enabled
@stephkaiser Requesting you approval on disable preview from CLI, few days back, I demoed it you. please let me know if you have any questions.
@stephkaiser Requesting you approval on disable preview from CLI, few days back, I demoed it you. please let me know if you have any questions.
no questions from me! looks good, thanks Jitendra!
Description
Resolves 1870
Development notes
--include-preview
flag added for Viz CLI:is_all_previews_enabled
forDataNodeMetadata
class which controls the enable/disable functionality for all the datasetsQA notes
kedro viz build --include-preview
to enable preview for all datasetskedro viz deploy --include-preview
to enable preview for all datasets in the deployed versionNOTE: As discussed with @rashidakanchwala and @stephkaiser ,
kedro viz run
will not have a preview flag and preview will be set to True by default. If the users want to change this behavior, they need to do this from UI. Designs will be updated soon (cc: @stephkaiser )Checklist
RELEASE.md
file