kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.
https://demo.kedro.org
Apache License 2.0
646 stars 106 forks source link

Enable/disable preview for all the datasets when publishing Kedro-Viz from CLI #1894

Closed jitu5 closed 1 month ago

jitu5 commented 1 month ago

Description

Resolves 1870

Development notes

QA notes

NOTE: As discussed with @rashidakanchwala and @stephkaiser , kedro viz run will not have a preview flag and preview will be set to True by default. If the users want to change this behavior, they need to do this from UI. Designs will be updated soon (cc: @stephkaiser )

Checklist

rashidakanchwala commented 1 month ago

There's also this ticket here #1705 , we can add this to next sprint.

merelcht commented 1 month ago

One thought is perhaps to name the new boolean after the new --include-preview flag, so it's clear those two are connected?

jitu5 commented 1 month ago

@rashidakanchwala Sure I will create a separate PR for change of is_preview_disabled to is_preview_enabled

jitu5 commented 1 month ago

@stephkaiser Requesting you approval on disable preview from CLI, few days back, I demoed it you. please let me know if you have any questions.

stephkaiser commented 1 month ago

@stephkaiser Requesting you approval on disable preview from CLI, few days back, I demoed it you. please let me know if you have any questions.

no questions from me! looks good, thanks Jitendra!