Enable/disable preview for all the datasets when publishing Kedro-Viz from UI

jitu5 commented 1 month ago

Description

Resolves #1870

On kedro viz run locally, now the users will have the preview enable/disable toggle(All dataset previews) on the publish pop-up through which they can control the deployable instance preview settings.

Development notes

Modified DeployerConfiguration class to accept is_all_previews_enabled from FE
Modified deployer.deploy function to accept is_all_previews_enabled
Updated tests

NOTE: There is an overlap between this PR and https://github.com/kedro-org/kedro-viz/pull/1894 . Changed the base to ease reviews. This PR will be merged after https://github.com/kedro-org/kedro-viz/pull/1894. Also the above mentioned UI changes is part of https://github.com/kedro-org/kedro-viz/pull/1907 PR. This PR will merge before https://github.com/kedro-org/kedro-viz/pull/1907 Also CLI flag name changes from --include-preview to --include-previews is added to part of this PR.

Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[x] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

rashidakanchwala commented 1 month ago

This is definitely much better than removing the keys, and it's good because deploy() function is accessible both in CLI and UI, so we can add that preview_flag there. Also agree with Ravi in future, if there are more customisations we could consider a DeployDataConfig class. Thanks @jitu5 and @ravi-kumar-pilla , great thinking on this approach :D

astrojuanlu commented 1 month ago

Is there any user-facing changes in this PR? Unclear to me just by looking at the code, do you mind attaching a screenshot of what should I be looking at?

ravi-kumar-pilla commented 1 month ago

Is there any user-facing changes in this PR? Unclear to me just by looking at the code, do you mind attaching a screenshot of what should I be looking at?

The UI for this is pending and I will attach it once @jitu5 is back. These are only the backend changes which I tested via Postman and it was working fine. I will move this to draft and will add more context next week once we decide on the final approach. Thank you

kedro-org / kedro-viz