Fix messaging level when package compatibility is not satisfied - Githubissues

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

646 stars 106 forks source link

Fix messaging level when package compatibility is not satisfied #1904

Closed ravi-kumar-pilla closed 1 month ago

ravi-kumar-pilla commented 1 month ago

Description

Resolves #1877

Development notes

Update log level to warning
Modify PACKAGE_REQUIREMENTS to have warning_message and min_compatible_version dict
Update tests

NOTE: Lint will be fixed with the PR - https://github.com/kedro-org/kedro-viz/pull/1903

QA notes

Start kedro viz run on a kedro project which does not use kedro-datasets
Users should see a warning message instead of error
All tests should pass

Checklist

[x] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[x] Added new entries to the RELEASE.md file
[x] Added tests to cover my changes

ravi-kumar-pilla commented 1 month ago

Hi @ankatiyar ,

Not related to this ticket but I was curious about the workflow - .github/workflows/docs-only-checks.yml

I see the workflow runs the linter but the linter has commands which are related to python and some secret scan etc. How is this helpful for doc changes ?
The trigger condition has .md files, so this will be triggered for all the PRs to main which have a release note and we also run backend linters separately which do almost the same.
Can we run this for only 1 python version, in case this is needed for any reason ?

cc: @Huongg

Thank you