Remove default props from functional components

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

646 stars 106 forks source link

Remove default props from functional components #1906

Closed Huongg closed 1 month ago

Huongg commented 1 month ago

Description

Fixes #1905

Development notes

I've removed the defaults props from our Functional components, set them directly in the props values instead

QA notes

All the tests have passed and everything seems to work fine form my side

Checklist

[ ] Read the contributing guidelines
[ ] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

Huongg commented 1 month ago

Looks great! I left one comment.

I did a project-wide find for defaultProps and found one left:

https://github.com/kedro-org/kedro-viz/blob/63cfeaa6e11b32b40052830e49ba267cf2ed9010/tools/test-lib/react-app/app.js#L80

But it's in the /tools/test-lib directory so I don't think it matters too much.

yeah I didn't remove it cause it seems like there was no error, but maybe best to remove it too, to be consistent with the rest