Closed ravi-kumar-pilla closed 14 hours ago
Hi Team,
Please let me know if the split PRs are hard to review. I could not find a better way to split as the initial changes were interlinked. If the PR as a whole is easy to review, I am happy to shift this info to #1897 . Thank you
Description
Resolves #1899 , #1814
Development notes
To ease review process for - https://github.com/kedro-org/kedro-viz/pull/1897 , created the below PRs
QA notes
Example modular pipeline tree:
Current issues in constructing the modular pipeline tree:
Incorrect rendering of nodes :
Issues raised by users -
How does this PR resolve the issues:
Core parts that changed:
populate_tree
,add_children
,_add_datasets_as_children
,_add_children_to_parent_pipeline
to ModularPipelinesRepository. (Thanks to @rashidakanchwala)populate_tree
to resolve the construction ofmodular_pipelines_tree
for the registered pipelineadd_children
and other helper functionsCode Flow doc:
Please find further information at Refactor_Modular_Pipelines.docx
Modular Pipelines UI Rendering:
UseCase 1: When a modular pipeline output (dataset_3) is used as an input to another function of the same modular pipeline.
Before:
After:
UseCase 2: When a nested modular pipeline output (dataset_3) is used as an input to the outer modular pipeline
Before:
After:
UseCase 3: When a nested modular pipeline output (dataset_3) is used as an input to the outer modular pipeline and also used as an input to another external modular pipeline
Before:
After:
UseCase 4: When an output of a namespace function (using node namespaces) (dataset_7, dataset_9) is an input to another function in the same namespace
Before:
After:
UseCase 5: When an output of a nested modular pipeline (model_inputs) is an input to another nested modular pipeline
Before:
After:
UseCase 6: Nested namespace pipelines with single input (input_to_processing) and single output (output_from_processing)
Before:
After:
Modular Pipelines expand and collapse in action:
Before:
UseCase 1-4:
UseCase 5-6:
After:
UseCase 1-4:
UseCase 5-6:
Checklist
RELEASE.md
file