Replace toposort with graphlib

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

646 stars 106 forks source link

Replace toposort with graphlib #1942

Open SajidAlamQB opened 2 weeks ago

SajidAlamQB commented 2 weeks ago

Description

Related to: #1820

This ticket aims at dropping toposort dependency in favor of built-in graphlib if possible.

Development notes

QA notes

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

ravi-kumar-pilla commented 5 days ago

Hi @SajidAlamQB ,

Nicely done. I was testing the PR and I see there is a minor issue in the UI. The order of layers is shifted -

Layers feature and model_input are shifted. Even the DAG has Feature Importance Output dataset after Model Input Table. Can you please test it on your side. Thank you

Before

After