Closed rashidakanchwala closed 2 months ago
Thanks @rashidakanchwala !
My only question (not a blocker) - any clue why this wasn't caught by unit tests?
excellent question and I am going to create an issue around it today. Ideally; this should be caught by e2e testing which we don't have any for kedro viz --lite
so I am going to ping Ravi to work on that.
Update - #2103
excellent question and I am going to create an issue around it today. Ideally; this should be caught by e2e testing which we don't have any for
kedro viz --lite
so I am going to ping Ravi to work on that.Update - #2103
Thanks @rashidakanchwala for fixing the issue and creating the ticket. I did add one e2e test only against the "latest" Kedro version. I will add more in the ticket #2103 . Thank you !
Description
This is to get Kedro-viz (mainly kedro viz --lite) to work with Kedro 18 and some Kedro 19 versions based on changes this PR (https://github.com/kedro-org/kedro/pull/3920) introduced.
In July, Kedro made the
_save
and_load
methods public. At that time, Kedro-viz did not rely on these methods. However, when we recently mergedkedro viz --lite
, we introduced an UnavailableDataset class, which is an AbstractDataset. This class now uses the public load and save methods. To maintain backward compatibility with older versions of the dataset, we followed a suggestion made by @deepyamanOriginally posted by @deepyaman in https://github.com/kedro-org/kedro/issues/3920#issuecomment-2176270399
QA notes
Checklist
RELEASE.md
file