Fix `Unable to get file size` when dataset has no protocol attribute - Githubissues

kedro-org / kedro-viz

Visualise your Kedro data and machine-learning pipelines and track your experiments.

https://demo.kedro.org

Apache License 2.0

682 stars 113 forks source link

Fix `Unable to get file size` when dataset has no protocol attribute #2174

Closed SajidAlamQB closed 2 weeks ago

SajidAlamQB commented 3 weeks ago

Description

Related to: https://github.com/kedro-org/kedro-viz/issues/1893

User reported getting Unable to get file size. Object has no attribute '_protocol' for DeltaTableDataset. This PR will aim to resolve it.

Development notes

Stopped relying on methods from kedro that rely on private attribute, use fsspec to find file size.

QA notes

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[ ] Updated the documentation to reflect the code changes
[ ] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

astrojuanlu commented 2 weeks ago

Added some thoughts on https://github.com/kedro-org/kedro-viz/issues/1893#issuecomment-2456833233