Add port in use check to prevent browser redirecting incorrectly for kedro viz

SajidAlamQB commented 2 weeks ago

Description

If there is an existing Kedro Viz server running, kedro viz run will redirect the browser to that one when a second instance of kedro viz is launched using the same port and the error message from uvicorn is missed.

Development notes

Check that the port is in use before running the server and increment it until a max 5 times to find an alternative free port, if none are found send error message to users no free ports available and suggest them to use --port.

QA notes

Checklist

[x] Read the contributing guidelines
[x] Opened this PR as a 'Draft Pull Request' if it is work-in-progress
[x] Updated the documentation to reflect the code changes
[x] Added new entries to the RELEASE.md file
[ ] Added tests to cover my changes

rashidakanchwala commented 2 weeks ago

hey @SajidAlamQB , can we not increment the port number here, directly, if 4141 is occupied, go to 4142, if that is occupied which is it always, go to 4143?

rashidakanchwala commented 2 weeks ago

maybe we put a specific range from 4141, to 4145, and if all the ports in this range are busy, then they tell us which one through --port.

SajidAlamQB commented 2 weeks ago

maybe we put a specific range from 4141, to 4145, and if all the ports in this range are busy, then they tell us which one through --port.

This is a good middle approach we definitely can do.

rashidakanchwala commented 2 weeks ago

@SajidAlamQB , thanks for this , will review this once tests are passing, can we also add unit-testing to this, if we can mock ports being occupied ?

kedro-org / kedro-viz