kedro-org / kedro-website

A repository for the official home of Kedro.
https://kedro.org/
3 stars 1 forks source link

Update Hero CTA buttons and Ready To Start section #177

Closed tynandebold closed 10 months ago

tynandebold commented 10 months ago

Description

Resolves #173

Development notes

I believe I've covered everything stated in #173.

QA notes

Check the deployed link and see if I missed anything.

@stephkaiser might want to take a quick look at the code formatting in the Ready to start? section.

Checklist

netlify[bot] commented 10 months ago

Deploy Preview for kedro-website ready!

Name Link
Latest commit 1abf177670c8b64b18805c16b66715f089a9dc3c
Latest deploy log https://app.netlify.com/sites/kedro-website/deploys/6554a7c21158ab0007a52157
Deploy Preview https://deploy-preview-177--kedro-website.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 81 (🟢 up 6 from production)
Accessibility: 91 (no change from production)
Best Practices: 83 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

stichbury commented 10 months ago

The preview looks great to me. Just one thing @tynandebold...there is an extra line of copy after the code snippets.

"For more details, see the set up documentation or watch the video." (where the link to the video is TBD, but should come today or soon).

The copy will sit between the code and the "Take the tutorial" lozenge and be in normal font, please.

Shall we see how that looks and I agree we need to get design to confirm, so ask @stephkaiser on her return.

tynandebold commented 10 months ago

Sorry I missed that line! Updated now.

stichbury commented 10 months ago

Sorry I missed that line! Updated now.

Very nice, thanks! All good for me, just waiting on that link now. Thanks!

stephkaiser commented 10 months ago

the flow and design of the text looks good to me!

there are other things we could do to improve the design of the website but as @astrojuanlu mentioned, we can tackle that in the future :)