search

kedro-org / kedro

Kedro is a toolbox for production-ready data science. It uses software engineering best practices to help you create data engineering and data science pipelines that are reproducible, maintainable, and modular.
https://kedro.org
Apache License 2.0
9.91k stars 900 forks source link

Update docs about building plugins to use `pyproject.toml` instead of `setup.py` #3053

Closed merelcht closed 11 months ago

merelcht commented 1 year ago

Description

The docs about building plugins for Kedro still mentions setup.py. We should update that to use pyproject.toml instead.

Context

This is inline with making the python packaging/plugin flow up to date with the current industry standards.

astrojuanlu commented 1 year ago

Maybe remilestone to https://github.com/kedro-org/kedro/milestone/36?

Otherwise, for general doc improvements, I think we have https://github.com/kedro-org/kedro/issues/1539 (and a duplicate I opened, #2685)

merelcht commented 1 year ago

That milestone is closed because the majority of the work is done. This could actually be a nice small ticket for Hacktoberfest.

stichbury commented 1 year ago

Parent ticket #1539

abhishek-nigam commented 1 year ago

Hi team at Kendo-Org, I would like to pick this up. Though I have about 4 years of experience in software engineering, I haven't really worked with medium-large Python projects. Also, this would be my first contribution in open-source projects, and I feel excited about it.

Shall I work on it? Thank you for building Kendro!

astrojuanlu commented 1 year ago

Hi @abhishek-nigam , welcome! Of course - no need to assign the issue, feel free to send a pull request for it whenever you're ready

stichbury commented 1 year ago

Hi @abhishek-nigam Just checking in to see how this is going for you? I've assigned you to it and marked as "In progress" but do let us know if you prefer to put it back in the backlog.

abhishek-nigam commented 1 year ago

Hi @stichbury ! The past week has been slightly hectic for me since I've been interviewing for jobs. Now, that I've made it past them, I am looking forward to starting with this task from Friday. I'll keep you posted about any questions that I have, my progress here.

stichbury commented 11 months ago

Hi @abhishek-nigam I'm not sure if you've had any time to tackle this issue but today is the last day of October, so just in case you've the work ready to go, but not yet got it in to our queue, now's the time to do so 🏃 💨

merelcht commented 11 months ago

I just realised this was already done as part of https://github.com/kedro-org/kedro/pull/3013. So I'll close this issue.