kedro-org / kedro

Kedro is a toolbox for production-ready data science. It uses software engineering best practices to help you create data engineering and data science pipelines that are reproducible, maintainable, and modular.
https://kedro.org
Apache License 2.0
9.53k stars 879 forks source link

Fix credentials throwing error on `kedro catalog resolve` #3712

Closed merelcht closed 4 months ago

merelcht commented 4 months ago

Description

Feed credentials to catalog in kedro catalog resolve command.

Development notes

This bug was reported by a user on Slack. In short the kedro catalog resolve command uses

DataCatalog.from_config(catalog=catalog_config)

But this is missing the credentials argument. If a user has credentials in a dataset that also uses dataset factories an error is thrown:

KeyError: "Unable to find credentials 'sql_tb_credentials': check your data catalog and credentials configuration. See https://kedro.readthedocs.io/en/stable/kedro.io.DataCatalog.html for an example."

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist