Closed ondrejzacha closed 3 months ago
I have some concerns to open up a lot of public methods which is unclear to me how will it be useful outside of this context (Maybe for using it in notebook? Would love to see some example of this if that's the case)
Sure, I don't have a strong preference here. In my work I've found myself pulling these methods out of the runner code to figure out how to continue a run of a pipeline which did not fail gracefully (ran into an OOM error and never showed this suggestion) – but I can imagine that can very much be an exception
I think from my side this is ready; the docs build is still failing so let me know if there's anything I can still do. Excited to see this merged, thanks for the reviews! 🤩
@ondrejzacha amazing, thanks again really appreciate the effort🙏 I will take over and merge this.
Description
Supersedes #3026
Addresses #3002:
Additionally:
Development notes
Additional tests added in
test_sequential_runner.py
– both to check the message in logs for sequential runner specifically, as well as a new suite of tests for the suggestion logic itself. I appreciate that the logic is not exactly straightforward, so please double check the tests / let me know if more tests are needed.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file