Closed noklam closed 6 months ago
Find the seemingly obsoleted MemoryDataset
used in ParallelRunner, remove and see CI agree.
Closed:
https://docs.python.org/3/library/multiprocessing.html#customized-managers
The complete story is that:
ParallelRunnerManager
inherit from SyncManager
MemoryDataset
is registered as a class method to ParallelRunnerManager
MemoryDataset
living in the ParallelRunnerManager
In a way SharedMemoryDataset
is a special wrapper dataset that coupled with the MemoryDataset
.
Can the branch be deleted? (Didn't want to do it myself just in case)
Description
Development notes
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file