kedro-org / kedro

Kedro is a toolbox for production-ready data science. It uses software engineering best practices to help you create data engineering and data science pipelines that are reproducible, maintainable, and modular.
https://kedro.org
Apache License 2.0
9.49k stars 875 forks source link

Tag names limitation #3785

Closed boringbyte closed 1 day ago

boringbyte commented 3 months ago

Description

Addresses https://github.com/kedro-org/kedro/issues/3727 This pull request was initiated to provide more information about valid node name and tag.

Development notes

make build-docs make lint

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

lvijnck commented 6 days ago

@datajoely slightly off-topic, but why do we enforce such a strict requirement on the tag values? AFAIK they are exclusively used to run targeted portions of the pipeline. Why do we not keep them more flexible?

datajoely commented 5 days ago

@lvijnck short answer was it was causing errors in different places so we've simplified the space, what extra flexibility would you want?