Closed DimedS closed 5 months ago
This is a fantastic start @DimedS ⭐ I have left some comments inline, but in general I think it would be useful to add some more context and explanations about why certain steps are needed. Also a minor note on referencing Kedro class names, when talking about a class in Kedro e.g.
DataCatalog
the best practice would be to use the exact class name or the regular english name for it e.g. data catalog, but not a hybrid like Data Catalog.
Thank you, @merelcht ! I agree and hope I've addressed your comments.
Woops
sphinx.errors.SphinxWarning: /home/docs/checkouts/readthedocs.org/user_builds/kedro/checkouts/3792/docs/source/deployment/index.md:48:toctree contains reference to nonexisting document 'deployment/airflow_astronomer'
I believe I've addressed most of the comments. Could you please do a final check, @ankatiyar , @merelcht , @astrojuanlu ?
@sbrugman By any chance do you have a moment to give this a look?
Description
This PR addresses issues 1, 2, 3, 5, and 6 from 605:
kedro-airflow-k8s
plugin has been relocated to the end of the document because it is compatible only with Kedro versions earlier than 0.17.astro-airflow-iris
starter has been replaced with the standardspaceflights-pandas
example pipeline.Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file