kedro-org / kedro

Kedro is a toolbox for production-ready data science. It uses software engineering best practices to help you create data engineering and data science pipelines that are reproducible, maintainable, and modular.
https://kedro.org
Apache License 2.0
9.49k stars 874 forks source link

Make `logging.yml` read by default #3801

Closed noklam closed 2 months ago

noklam commented 3 months ago

Quick summary:

  • :white_check_mark:There are at least one obvious user problem - which is logging get chosen as a tool but has no effect, and the consensus is that we should fix it. - https://github.com/kedro-org/kedro/issues/3446
  • It's unclear whether we should do more for logging, such as adding a new -v flag
  • It's mentioned logging in development and logging in production are very different, and users probably have different needs:
    • It was mentioned we may want to de-couple rich as a plugin, pip-uninstallable to deactivate it or at least provide an easy enough way to opt out from it.
  • We may consider improving the messaging of logging and people should seek for production grade logging.
  • It was mentioned even though there are users need, Kedro can still say NO as we had for many other things.

Antony shared the old user research here in case you miss it at the end: https://github.com/kedro-org/kedro/issues/2281#issuecomment-1471805422

Originally posted by @noklam in https://github.com/kedro-org/kedro/discussions/3755#discussioncomment-9009731

Context

Since 0.19, we introduced a few changes:

This create a bad UX because:

The scope of ticket is to implement a fix to make sure the default file is read. KEDRO_LOGGING_CONFIG will take priority when it is provided. (See https://github.com/kedro-org/kedro/commit/be3d28d981ecf51d8fef96a256d9c0ef74d5d8c4 for inspiration)

Solution

https://github.com/kedro-org/kedro/commit/be3d28d981ecf51d8fef96a256d9c0ef74d5d8c4 is a good starting point. At the minimal case, the happy path of

There are things to consider:

#

SajidAlamQB commented 2 months ago

Completed in https://github.com/kedro-org/kedro/pull/3831