search

kedro-org / kedro

Kedro is a toolbox for production-ready data science. It uses software engineering best practices to help you create data engineering and data science pipelines that are reproducible, maintainable, and modular.
https://kedro.org
Apache License 2.0
9.48k stars 874 forks source link

Update pluggy requirement to remove the upper bound pin #3828

Closed dependabot[bot] closed 2 months ago

dependabot[bot] commented 2 months ago

Updates the requirements on pluggy to permit the latest version.

Changelog

Sourced from pluggy's changelog.

pluggy 1.5.0 (2024-04-19)

Features

  • [#178](https://github.com/pytest-dev/pluggy/issues/178) <https://github.com/pytest-dev/pluggy/issues/178>_: Add support for deprecating specific hook parameters, or more generally, for issuing a warning whenever a hook implementation requests certain parameters.

    See :ref:warn_on_impl for details.

Bug Fixes

  • [#481](https://github.com/pytest-dev/pluggy/issues/481) <https://github.com/pytest-dev/pluggy/issues/481>_: PluginManager.get_plugins() no longer returns None for blocked plugins.

pluggy 1.4.0 (2024-01-24)

Features

  • [#463](https://github.com/pytest-dev/pluggy/issues/463) <https://github.com/pytest-dev/pluggy/issues/463>_: A warning :class:~pluggy.PluggyTeardownRaisedWarning is now issued when an old-style hookwrapper raises an exception during teardown. See the warning documentation for more details.

  • [#471](https://github.com/pytest-dev/pluggy/issues/471) <https://github.com/pytest-dev/pluggy/issues/471>_: Add :func:PluginManager.unblock <pluggy.PluginManager.unblock> method to unblock a plugin by plugin name.

Bug Fixes

  • [#441](https://github.com/pytest-dev/pluggy/issues/441) <https://github.com/pytest-dev/pluggy/issues/441>_: Fix :func:~pluggy.HookCaller.call_extra() extra methods getting ordered before everything else in some circumstances. Regressed in pluggy 1.1.0.

  • [#438](https://github.com/pytest-dev/pluggy/issues/438) <https://github.com/pytest-dev/pluggy/issues/438>_: Fix plugins registering other plugins in a hook when the other plugins implement the same hook itself. Regressed in pluggy 1.1.0.

pluggy 1.3.0 (2023-08-26)

Deprecations and Removals

  • [#426](https://github.com/pytest-dev/pluggy/issues/426) <https://github.com/pytest-dev/pluggy/issues/426>_: Python 3.7 is no longer supported.

Features

... (truncated)

Commits
  • f8aa4a0 Preparing release 1.5.0
  • b4a8c92 Merge pull request #495 from bluetech/warn-on-impl-args
  • 6f6ea68 Add support deprecating hook parameters
  • 91f88d2 Merge pull request #496 from bluetech/codecov-action
  • 89ce829 ci: replace upload-coverage script with codecov github action
  • 29f104d Lift pluggy (#493)
  • c2b36b4 Merge pull request #491 from pytest-dev/pre-commit-ci-update-config
  • 2b533c9 [pre-commit.ci] pre-commit autoupdate
  • 04d1bcd [pre-commit.ci] pre-commit autoupdate (#490)
  • f74e94b [pre-commit.ci] pre-commit autoupdate (#489)
  • Additional commits viewable in compare view


Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- | | pluggy | [>= 1.3.a, < 1.4] |

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
ankatiyar commented 2 months ago

This should go in, pytest 8.1.1 requires pluggy>1.4 and we have pinned it to be <1.4. So right now our tests are running on a lower version of pytest which is fine but if you install kedro-viz with the test requirements, they've got pytest pinned to a ~=8.1 which is causing some version conflicts

ankatiyar commented 2 months ago

https://github.com/kedro-org/kedro-viz/actions/runs/8832932256/job/24251199905 kedro-viz CI is uninstalling Kedro from main and resolving to 0.19.2 in their tests

rashidakanchwala commented 2 months ago

If it helps, I can relax the pin on kedro-viz, it's internal anyway.

ankatiyar commented 2 months ago

@rashidakanchwala The tests are passing here so it's fine to unpin here. @noklam It was pinned in https://github.com/kedro-org/kedro/pull/3552, what do you think?

noklam commented 2 months ago

This should go in, pytest 8.1.1 requires pluggy>1.4 and we have pinned it to be <1.4. So right now our tests are running on a lower version of pytest which is fine but if you install kedro-viz with the test requirements, they've got pytest pinned to a ~=8.1 which is causing some version conflicts

kedro-viz test requirements should not interact with kedro[test], our test requirements are separate so I am not sure why kedro-viz is involved here.

On the other hand, if this works fine with our test then I don't see a problem merging this.