kedro-org / vscode-kedro

Kedro extension for VSCode including LSP and other features
https://marketplace.visualstudio.com/items?itemName=kedro.Kedro
Apache License 2.0
18 stars 2 forks source link

Support filtering of pipelines #123

Open noklam opened 1 month ago

noklam commented 1 month ago

Description

image

https://demo.kedro.org/?types=nodes,datasets&pid=__default__&expandAllPipelines=false support filtering via the pannel, this is missing in the extension and several user has mentioned this make most project unusable.

I recalled @astrojuanlu mentioned somewhere, base on our telemetry this select filter has very low usage.

Context

This make the viz integration unusable for realistic pipeline (100+ nodes). See notes https://github.com/kedro-org/vscode-kedro/issues/140

Alternative

astrojuanlu commented 1 month ago

base on our telemetry this select filter has very low usage.

Based on anecdotal evidence 😅 we haven't analysed the telemetry yet

stephkaiser commented 1 week ago

(The summary below tackles both https://github.com/kedro-org/vscode-kedro/issues/123 & https://github.com/kedro-org/vscode-kedro/issues/136)

Summary

Our chosen solution:

Designs can be found here - https://www.figma.com/design/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?node-id=2936-125807&t=Km8oiXjUlRyVBUMk-4

astrojuanlu commented 1 week ago

Thanks a lot for the summary @stephkaiser . One thing I don't understand - is the idea that, after clicking the filter button, the VS Code Command Palette would open with the value >kedro pre-populated?

For the UI, have we explored the possibility of using the left menus?

image
noklam commented 1 week ago

Base on the last discussion, I learn that the interaction between that sidebar and the visualisation is one of the most complicated part in Viz, so it is a bigger engineering challenge and will take more time. I assume you want to use the sidebar with native VSCode component? Or do you mean re-using the kedro-viz react sidebar?

On the other hand, having a command -> trigger a drop down does not conflict with this, since it enable a keyboard workflow with shortcut, and the implementation is clear (can be achieved in a relatively short time).

On design side @stephkaiser will have more comment on this.

stephkaiser commented 1 week ago

Thanks a lot for the summary @stephkaiser . One thing I don't understand - is the idea that, after clicking the filter button, the VS Code Command Palette would open with the value >kedro pre-populated?

Yes thats the idea, it will open with the filter command pre-populated so for example: >kedro: Filter Viz by pipeline

For the UI, have we explored the possibility of using the left menus?

Yes we have, you can see all the other ideas in the Miro board link above. The TL;DR is this solution wasn't the ideal user experience because of its positioning on the left side - this list panel is related to viz flowchart but code is separating both of these kedro-viz components so interacting and selecting something in the left side and viewing it on the right side felt disjointed. Interacting with the list panel also won't affect the code section next to it, only the viz flowchart. This list component is also complex to implement from an engineering perspective.

astrojuanlu commented 1 week ago

Oh I hadn't seen the Miro, only Figma 👍🏼 thank you for the extra context!

stephkaiser commented 1 week ago

no problem! 🙂 keep in mind this is the v1 proposal that we thought was relatively low effort and easy to implement. When we get more feedback and ideas to explore for the kedro viz extension, we can revisit the list menu idea on the left

astrojuanlu commented 1 day ago

We have to create specific tickets cc @jitu5