search

kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

Make KeeFox work with Thunderbird #107

Closed luckyrat closed 11 years ago

luckyrat commented 11 years ago

Could a Thunderbird extension be created, too?

luckyrat commented 11 years ago

Imported from trac issue 95. Created by elieux on 2011-05-29T17:57:35, last modified: 2012-12-10T15:49:09

luckyrat commented 11 years ago

Trac comment by luckyrat on 2011-06-02 23:32:16:

I think it would be possible in theory but I don't think I'd have time to implement it myself.

If anyone wants to try to port the extension to thunderbird then please just let me know, if it's possible it would be good to keep the two solutions integrated but it may have to be released as a separate add-on specifically for Thunderbird.

In the mean time I'll just point you to the more keyboard orientated approach of "!AutoType" which !KeePass supports for any application: http://keepass.info/help/base/autotype.html

luckyrat commented 11 years ago

Trac comment by luckyrat on 2012-07-19 23:32:07:

Please try KeeFox 1.1 which supports Thunderbird (thanks to https://github.com/dlech). It's currently in beta testing and depending on how much feedback I receive during the beta testing period, I may release it as a stable version when version 1.1 is released in a few weeks time.

KeeFox 1.1 is available for beta testing here: https://addons.mozilla.org/en-US/firefox/addon/keefox/versions/

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-20 09:13:28:

After I installed the beta, wondered why it doesn't do anything, updated the KeePass RPC plugin (after being reminded by Firefox, where I installed the beta, too), I got stuck at the 'Enter your password' dialog, unable to confirm (neither by pressing OK, nor by hitting Enter).

Also, it seems that IMAP password dialogs get the 'No matching entries found' row, while POP password dialogs don't have it. Neither have the 'Remember password' checkbox.

I'm not sure if this is an add-on conflict, misconfigured Thunderbird or a genuine bug. I'm gonna try disabling other add-ons later today and report the results here. (I have already disabled the Hostname in Titlebar add-on, but it didn't make much of a difference.)

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-23 07:21:54:

So yeah, even after disabling all add-ons, POP passwords dialogs weren't showing any sings of KeeFox and I couldn't confirm the password I auto-typed in.

IMAP dialogs show up, get filled and confirmed like a charm.

luckyrat commented 11 years ago

Trac comment by luckyrat on 2012-07-23 18:42:24:

Thanks for the bug report.

I've just released KeeFox 1.1.0b2 which addresses the problem with pressing OK.

Does that also fix the issue with POP password dialogs?

https://addons.mozilla.org/en-US/firefox/addon/keefox/versions/

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-24 10:11:00:

Replying to [comment:5 luckyrat]:

I've just released KeeFox 1.1.0b2 which addresses the problem with pressing OK.

Thanks, now it works.

Does that also fix the issue with POP password dialogs?

Nope. I see no change. SMTP password dialogs work, by the way. (I don't know if they worked in the previous version.)

To keep things interesting, the updated Firefox version doesn't work for me - looks like it's incompatible (no KeeFox Toolbar, cannot open Options).

luckyrat commented 11 years ago

Trac comment by luckyrat on 2012-07-25 00:55:50:

Which version of Firefox are you running?

It works fine for me in v14.0.1

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-25 09:14:55:

Huh. Reinstalling the add-on solved the "incompatibility". For some mysterious reason, the add-on directory contained just modules, icon.png and install.rdf. Sorry for the false alarm.

Any progress on the POP password dialogs? Should I test something, get some logs?

luckyrat commented 11 years ago

Trac comment by luckyrat on 2012-07-25 19:49:13:

That's good - although it sounds like the Firefox add-on update process failed for some reason which is quite surprising. I'd hazard a guess that the files were locked by some other process (Thunderbird?) when it was trying to do the update but it's a bit weird.

dlech has just added support for the POP password dialogs so I've uploaded version 1.1.0b3:

https://addons.mozilla.org/en-US/firefox/addon/keefox/versions/

Let us know how you get on.

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-26 11:54:40:

Excellent. All passwords (6 POP's in db 1, 1 IMAP in db 2 and 1 IMAP in db 3) filled themselves in. Thunderbird restarts aren't going to be a hassle anymore, thanks.

luckyrat commented 11 years ago

Trac comment by elieux on 2012-07-31 12:51:38:

I've got access to two accounts on the same IMAP server. When I associate both entries in KeePass with the server name (according to the [wiki:Manual/Thunderbird]), I can't log into one of the accounts (the one displayed first in KeePass), presumably because KeeFox chooses always the other password.

I've set KeeFox to "Fill in and submit the login prompt" but haven't enabled "Forms with multiple matches should be automatically filled and submited".

luckyrat commented 11 years ago

Trac comment by dlech27 on 2012-07-31 14:54:38:

@elieux

Thanks for being an awsome tester. My intention is to eventually have KeeFox look at the username as well as the password for a match. However, this will take some doing (maybe in 1.2). For now though, I will try to fix it so that it obeys the "Forms with multiple matches..." setting.

@luckyrat

When I get around to matching the username, I was planning on hijacking the realm field to get the username back to KeePassRPC. Let me know if this sounds like a good idea or if you have a better one.

luckyrat commented 11 years ago

Trac comment by dlech27 on 2012-07-31 15:32:42:

Correction:

My intention is to eventually have KeeFox look at the username as well as the HOSTNAME for a match.

luckyrat commented 11 years ago

Trac comment by elieux on 2012-12-10 07:35:18:

One more thing. I decided to merge my KeePass email entries (one for each account instead of one for each protocol/account combination) and KeeFox stopped recognizing the entries. The entries are set up like this: {{{ Title: Gmail User Name: ****_@gmail.com - {REF:U@I:4441FE8F304D074A975BC532194A7C6F} Password: _**** URL: fake://keefox KPRPC Alternative URLs: imap.gmail.com pop.gmail.com smtp.gmail.com }}} When I removed the additional KPRPC Alternative URLs, the entry started to work again.

By the way, how is the "Form with multiple matches" fix and/or username/hostname matching feature going?

luckyrat commented 11 years ago

Trac comment by elieux on 2012-12-10 07:36:59:

Now I realized the username/hostname matching is in #126, so I'm putting it here for future reference.

luckyrat commented 11 years ago

Trac comment by dlech27 on 2012-12-10 15:49:09:

I have been putting it off quite successfully, but I am getting sufficiently annoyed having to click OK a bunch of times every time I open my email, so I will try to make it a priority now.

luckyrat commented 11 years ago

Since Thunderbird support has been in the main KeeFox release for some months now I think we'll mark this as done. Obviously there are still features to implement and bugs to fix but they are better dealt with as separate issues.