kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

KeeFox plugin prevents editing "Alternative URLs" custom string #124

Closed luckyrat closed 11 years ago

luckyrat commented 11 years ago

I tried creating a new forum topic for this first, but keep getting "Firefox has detected that the server is redirecting the request for this address in a way that will never complete." whenever I press "NEWTOPIC" button.

I've been using "Alternative URLs" (AURLs from now on) custom string to combine several entries created by KeeFox. Since some version of KeeFox I started noticing the following:

KeePass is showing AURLs value for an entry -- you can see it at the bottom of the main window when entry is selected. But when I try to edit the entry and go into Advanced tab, AURLs string is not listed among String fields. So you cannot edit it. If you press Ok to close "Edit Entry" window without making any changes it'll still delete associated AURLs. So you have to cancel editing.

If I uninstall KeeFox plugin (close KeePass, delete KeePassRPC.plgx, restart KeePass) -- editing AURLs works again.

Firefox 7.0.1 KeePass 2.17 KeeFox 0.9.3

Reproduced this on WinXP 32-bit and Win7 64-bit.

luckyrat commented 11 years ago

Imported from trac issue 112. Created by alexeip on 2011-11-03T19:20:44, last modified: 2011-11-28T20:55:33

luckyrat commented 11 years ago

Trac comment by luckyrat on 2011-11-04 00:04:29:

Sorry about the forum bug. Sourceforge said they were going to fix this "soon"... two years ago.

In the mean time, clearing all sourceforge.net cookies does the trick - which is fine, once you know the secret!

Either way, it does no harm to have this sort of problem discussed here instead (if anything it's better but it's hard to know and even harder to explain where the line should be drawn between topics suited to forum discussion and those suited to bug/feature request tickets).

The AURL problem looks like a bug in the code I wrote to try to ease the transition from the old custom string names to the new ones (prefixed with "KPRPC"). I'll try to fix it in future provided it's not going to cause problems for those with the new variations but in the mean time you should be able to fix up your entries by going to the KeeFox/URLs tab; double click each URL, click OK and then click OK to "save" the entry. Again, fine once you know the secret ;-)

Hope that helps, Chris

luckyrat commented 11 years ago

Trac comment by alexeip on 2011-11-04 00:42:15:

Ah, so "Alternative URLs" is being deprecated in favor of "KPRPC Alternative URLs" and the refresh trick above moves the values.

Thanks for the quick reply. I've just refreshed all the relevant entries in my db (easy to do if you make both columns visible in KeePass).

Wouldn't you say, though, that current implementation is a bit dangerous? Whenever someone edits any part of an entry he'll end up loosing AURLs value without even realizing it.

luckyrat commented 11 years ago

Trac comment by luckyrat on 2011-11-28 20:55:33:

I completely agree and have been able to fix the bug without any obvious side-effects. The fix will be in the next version of KeeFox although I'm not sure when I'll be able to release it just yet.

Thanks, Chris