KeePass doesn't exit on Mono after KeeFox plugin installation

[gordonmessmer]

In KeePassRPC/KeePassRPCService.cs, there's this function:

    public void destroy()
    {
        // why?
        lock (this)
        {
            // why?
            System.Threading.Monitor.Pulse(this);
        }
    }

As far as I can tell, removing the content of that function fixes the problem.

    // why?
    public void destroy()
    {

    }

My tests are incomplete, currently. I built the plgx by hand under Fedora following the post-build event script. It appeared to load under KeePass, but KeeFox didn't work. I'm guessing that I'd need to rebuild the whole thing, which seems like more work than I'm going to get to, near term.

[luckyrat]

Hmmm, as I noted some time ago, "why?" :-)

Looks like this code was important in the pre-release version of KeeFox but I can't think of any reason to keep it around any longer.

Quite why it's now caused a problem in your environment is a little mysterious. My best guess is that there is either a bug in Mono or just some relatively unusual behaviour in another KeePass plugin you have installed. Either way, if removing this helps, I can't see any good reason to keep it around so I'll get rid of it in 1.2.0a6.

When this ticket gets closed shortly, you can grab the new build from https://github.com/luckyrat/KeeFox/blob/master/XPI-package/latest.xpi?raw=true

Thanks for letting us know about this.

[gordonmessmer]

Thanks. I downloaded latest.xpi, but it looks like the plgx file was built on Feb 5.

The plugin in general doesn't appear to work at all. All of the strings are what look like IDs that begin and end in %, IIRC. I can't do any http basic auth at all when the plugin is installed and active. Do you want a bug report on that, or should I just wait and try some future build?

[luckyrat]

Try clearing your cache and redownloading. If that doesn't help I'll take a fresh look in the next day or two.

On 19 February 2013 03:54, gordonmessmer notifications@github.com wrote:

Thanks. I downloaded latest.xpi, but it looks like the plgx file was built on Feb 5.

The plugin in general doesn't appear to work at all. All of the strings are what look like IDs that begin and end in %, IIRC. I can't do any http basic auth at all when the plugin is installed and active. Do you want a bug report on that, or should I just wait and try some future build?

— Reply to this email directly or view it on GitHubhttps://github.com/luckyrat/KeeFox/issues/152#issuecomment-13755721.

[gordonmessmer]

The MD5sum of the file was the same as the previous one, and the strings were the same.

Thanks for looking at this.

[luckyrat]

The MD5 of the file I get when downloading from that URL is: 3C2C477149CBB25CA9A016840D939D00

There must be some misbehaving cache between your browser and github but you can use this URL that's unique for the precise version I committed last night: https://github.com/luckyrat/KeeFox/blob/901021d20be8593ee6a3de7dbaaa7b02ed76e460/XPI-package/latest.xpi?raw=true

[luckyrat]

I've just tried installing the latest build on a test machine and it looks like something else was wrong. I've uploaded another new version here: https://github.com/luckyrat/KeeFox/blob/e9eb01002e201bec23cdca7f0415e42aaade8904/XPI-package/latest.xpi?raw=true

[gordonmessmer]

The new XPI has the same issue on my system.

[luckyrat]

What version of the KeeFox addon and KeePassRPC plugin are instaleld on your system by the latest XPI?

[gordonmessmer]

The Firefox plugin is 1.2.0a8, the KeePass plugin is 1.1.7.0.

I also tried removing localstore.rdf and all references to keefox from my Firefox profile to reset it, and then installing the plugin again. The problems persist.

[krbvroc1]

Just an FYI, I get the same screenshot/result under Fedora 18. This is after installing the XPI into a newly created firefox profile, prior to any install mono. Is this related to the new translation stuff you were talking about? Is something not translating the strings?

[luckyrat]

Could just as likely be some other bug that affects Linux only. The strings won't get translated if part of the startup routine fails.

Do you see anything suspicious in the log or error console?

On 20 February 2013 18:44, krbvroc1 notifications@github.com wrote:

Just an FYI, I get the same screenshot/result under Fedora 18. This is after installing the XPI into a newly created firefox profile, prior to any install mono. Is this related to the new translation stuff you were talking about? Is something not translating the strings?

— Reply to this email directly or view it on GitHubhttps://github.com/luckyrat/KeeFox/issues/152#issuecomment-13848777.

[gordonmessmer]

There's a lot of this, always the same line:

Timestamp: 02/20/2013 01:47:54 PM Error: keefox_org is undefined Source File: resource://kfmod/KF.jsm Line: 1611

[dlech]

This is the same problem I had when doing my recent development work and the reason that I changed the file extensions. Is there something that renames files when you are packaging the .xpi file?

[luckyrat]

Please see #154

@dlech Thanks for the tip. This time it's turned out to be a different underlying problem to the one you had when developing on the new version but let me know if you still can't get things working correctly... actually I had replied to you on #151 a few days ago but I can't see the message there anymore. Maybe it failed to go through so I'll try to remember what I wrote and do it again later or tomorrow!