kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

Set default buttons in KeePassRPC (KeeFox) Options dialog #158

Closed elieux closed 11 years ago

elieux commented 11 years ago

The dialog doesn't respond to either Enter, nor Escape key. I assume this can be fixed by setting some properties of the dialog.

elieux commented 11 years ago

I want to attach a diff patch that should fix this, but I have no idea how to attach files here, so sorry for doing it this (probably wrong) way.

diff --git a/KeePassRPC/Forms/OptionsForm.Designer.cs b/KeePassRPC/Forms/OptionsForm.Designer.cs
index 33e5466..a099720 100644
--- a/KeePassRPC/Forms/OptionsForm.Designer.cs
+++ b/KeePassRPC/Forms/OptionsForm.Designer.cs
@@ -112,9 +112,11 @@
             // 
             // OptionsForm
             // 
+            this.AcceptButton = this.m_btnOK;
             this.AutoScaleDimensions = new System.Drawing.SizeF(6F, 13F);
             this.AutoScaleMode = System.Windows.Forms.AutoScaleMode.Font;
             this.BackColor = System.Drawing.Color.White;
+            this.CancelButton = this.m_btnCancel;
             this.ClientSize = new System.Drawing.Size(386, 173);
             this.Controls.Add(this.checkBox2);
             this.Controls.Add(this.label2);
luckyrat commented 11 years ago

Good suggestion. It'll be in 1.2.1b1 shortly.

I don't think you can attach files. For anything bigger than this, you can make a pull request from your forked version of the repository (actually even for just a couple of lines it is neater to have all code changes tracked via pull requests but I'd understand if you don't have time to justify the overhead, especially if you're not a regular git user - there's a bit of a learning curve.)

elieux commented 11 years ago

I wanted to take this as a opportunity to finally download git and start using it, but I found out that the console git for Windows is a monstrosity, so I cloned the repo and put the package away. If I happen to make more changes, I will do it the proper way.

luckyrat commented 11 years ago

Yeah it is! Have you tried github's "git for windows" application? ( http://windows.github.com/) Seems a lot nicer than most other clients but I've not used it myself (I'm used to the TortoiseSVN program so now use TortoiseGit).

On 18 March 2013 23:43, elieux notifications@github.com wrote:

I wanted to take this as a opportunity to finally download git and start using it, but I found out that the console git for Windows is a monstrosity, so I cloned the repo and put the package away. If I happen to make more changes, I will do it the proper way.

— Reply to this email directly or view it on GitHubhttps://github.com/luckyrat/KeeFox/issues/158#issuecomment-15089343 .