Closed elieux closed 10 years ago
I've seen this occasionally when using TabMixPlus but the fact you don't have that installed indicates that it might be a timing issue rather than something specific to TMP. Maybe TMP takes a long time to start or in some way alters the normal startup behaviour of Firefox such it breaks other addons like KeeFox which rely on an accurate indication of when a window is loaded and ready to be initialised with the KeeFox toolbar and other code.
It could be that multiple addons are able to trigger this behaviour but without more investigation I can't say whether it's likely to be a problem triggered by a certain behaviour in other addons or an issue that just happens to be more likely to occur with certain addons due to the length of time that they take to startup (or even the order in which Firefox starts all the addons).
To diagnose this further, we'll need to look at the keefox_win.mainEventHandler defined in keefox.js - maybe the currentWindow var passed to handleEvent() or the _assignedWindow property is not being set correctly in some circumstances?
Also worth noting that this file (and most others) currently run in strict mode but since it's very difficult to reliably test and debug issues that arise from enabling this mode, I'm intending to disable it for most or all files for the next (last?) 1.2.x beta (with the intention of re-enabling it for the 1.3 beta testing period and hopefully keeping it enabled for the 1.3 or 1.4 stable release). So maybe we could try changing this line in keefox.js:
"use strict";
to
"use non-strict";
Technically we could just remove the line but this makes it easier to track which files we want to enable or disable strict mode in and allows for a quick find and replace across all files when mass enabling or disabling the strict mode feature.
I'll not have time to look into this for at least a few days so if you want to take a look feel free and please let me know if you discover anything.
Oh yeah, one other thing that occurred to me is that the problems may have started around the same time as I started using pinned tabs.
I don't know anything about how they are implemented but the fact that they seem to be "always loaded" rather than "lazy loaded" suggests this might have something to do with it.
I've been unable to fix this and unable to verify whether the problem occurs in older versions of KeeFox (because I'm unable to reliably reproduce the problem in a dev environment).
Unfortunately, it looks like we'll just have to hope that it doesn't occur too frequently when KeeFox 1.2 is released.
What I've discovered so far:
Since you don't use TMP, there must be something else that can cause the same problem. If you could narrow down the problem to a single add-on, we might be able to home in on whatever part of TMP and the other addon are triggering this problem.
I appreciate your effort. I will try to find out which add-on(s) is causing this, but I can't give you any date as don't have much free time nowadays.
Just for reference, this is what happened today, when I updated KeePassRPC before updating KeeFox:
I exited Firefox cleanly, updated KeePassRPC (because Thunderbird -- having newer KeeFox version -- complained) and started Firefox. When Firefox was starting, it showed only 2 tabs (I think), with one of them being the upgrade page. Then the rest of the tabs loaded and the upgrade page stayed on the second tab (instead of Facebook, that was there originally) and the last (rightmost) tab activated/opened itself. I could see the add-ons load progressively on the right side of the address bar (not shown in the picture), where I keep add-on buttons.
On first start-up, Firefox had been unresponsive for a while, so I killed it. On second try, it loaded completely and I could go to Add-ons to upgrade KeeFox.
For comparison, this is how the title+tab bar looks normally:
I don't recall seeing this behaviour with the upgrade to 1.2.7 or 1.3.0b1. Here's hoping there was just some sort of Firefox bug that's been fixed now!
If we get all users upgraded to v 1.3 without seeing this again, I'll close the issue.
Today's upgrade went fine.
I've not seen a problem like this for ages so I'm putting it down to a now-resolved 3rd party bug, possibly Firefox.
I suspect this is caused by something in my Firefox profile, but it happened enough times I want to mention it and ask for help.
Sometimes (maybe only after Firefox crash/termination) when KeeFox wants to show me the upgrade page (because it's detected KeePassRPC is different version than the one bundled with the add-on), it causes all other tabs to lose their favicons and when I click on any of them, they pretend to load for a second and then stay blank and the address bar is blank, too.
I have "Don't load tabs until selected" enabled and various add-ons installed. I suspect the issue is somewhere among that setting and "Load Tabs Progressively", "Location Bar Enhancer", "Omnibar" add-ons and of course KeeFox.
I'm OK with no-one except myself working on this, but will appreciate any help provided.
List of my add-ons formatted as "[name] [version] [enabled] [id]":