kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 49 forks source link

KeeFox menu button disappeared. #289

Closed tea2code closed 10 years ago

tea2code commented 10 years ago

Hi,

with the new version the menu button disappeared completely. It was previously beside the addressbar but wasn't there anymore after updating to 1.4.2. Checking the customize menu it wasn't there either. I've already tried reinstalling KeeFox and disabling addons like Classic Theme Restorer but for no avail. Other than that KeeFox works perfectly. Passwords are inserted and the toolbar is shown if KeePass isn't open yet.

Thanks for your work :+1:

luckyrat commented 10 years ago

Have you checked if there is an overflow menu on your addressbar? Sometimes Firefox puts buttons in there if it thinks there is no room on the main toolbar (a decision it definitely got wrong in at least one circumstance in FF29).

Which version of Firefox are you running?

If you look at the Browser console (ctrl-shift-J) after starting Firefox, is there anything KeeFox-related in there?

Firefox should remember your preferred button positions even across an add-on reinstall so if it has somehow got pushed into an invalid location, reinstalling might not help. Have you looked on Firefox support for more general "can't find a button" problems?

tea2code commented 10 years ago

Found it (maybe it was the invalid location problem). It seems that after updating to FF30 KeeFox and some other buttons disappeared completely into nirvana. Pushing the "Reset Defaults" button in customize did the trick. Now everything is where it should be. Sorry for the wrong report.

krbvroc1 commented 10 years ago

@luckyrat - Same problem here - 'Restore Defaults' did resolve the issue, before hitting restore defaults there were no Keefox icons. I even uninstalled Keefox (because I was running 1.4.2b2) and installed the non-developer version 1.4.2 thinking making the fix wasn't in the developer version. Both had the same issue of no icons. Hotkeys worked in both cases.

luckyrat commented 10 years ago

Seems to be quite a few people having this issue, but not just with KeeFox. If it continues to be a problem with upgrades from FF30 to FF31+ I'll take a look at the Firefox bug tracker to see if I can find some clues about what's going on.

Dunes commented 10 years ago

I had the same problem after upgrading to FF30. In the browser console the following exception occurred. After resetting defaults the exception no longer appears.

"[CustomizableUI]" "[Exception... "Node was not found" code: "8" nsresult: "0x80530008 (NotFoundError)" location: ""] -- undefined:1014"

Alex9001 commented 10 years ago

Mine also disappears randomly. If I put it into the tab bar it stays put.

e-motiv commented 9 years ago

FYI for anyone who wants to troubleshoot. I might have the same problem (since FF 33 or 34): Keefox (and one other, Fastest Search addon) keep disappearing, even after bringing them back via "+ Customize". Consistently.

luckyrat commented 9 years ago

@e-motiv does the problem occur when you only have KeeFox and/or Fastest Search addons installed?

As far as troubleshooting goes, I don't think there's anything anyone can do apart from those people that are experiencing the problem. I can only suggest doing a Firefox profile reset or maybe looking at Firefox sync settings - perhaps the problem keeps reoccurring due to a change that is being (or not being) made in another profile that is synced to the profile that has problems.

If you can explain a way to reproduce the problem in a fresh Firefox profile I'll definitely take a look in case there is anything we can do to help work with the Firefox team to narrow down the cause of the problem.

Thanks.

Alex9001 commented 9 years ago

This happens even with a fresh profile on my system. I have bookmark folders on the same toolbar as the address bar and all the addon buttons, putting keefox on this toolbar makes it disappear when firefox is restarted after some use. However, putting it into the tab bar allows it to remain persistent. I've attached a screenshot of my layout and my browser.uiCustomization.state is below. Could it have something to do with the icon size or alignment? It looks smaller and out of place among the others and also forces the new tab button to be aligned to the right if placed prior to "new tab" in tab bar. sshot-2

{"placements":{"PanelUI-contents":["openwith-widewidget","privatebrowsing-button","preferences-button","add-ons-button","sidebar-button","https-everywhere-button","controledescripts-button","thumbnailzoomplus-toolbar-button","greasemonkey-tbb","flashgot-tbb-all","action-button--jid1-dgnibwqga0sibwjetpack-igtranslator"],"addon-bar":["addonbar-closebutton","status-bar"],"PersonalToolbar":[],"nav-bar":["personal-bookmarks","urlbar-container","social-share-button","policeman-toolbarbutton","cookiemonster-status","noscript-tbb","abp-toolbarbutton","feed-button","ublock-button","bluhellfirewall-toolbar-button","keefox-button","tabview-button","search-container","downloads-button","flashgot-media-tbb"],"TabsToolbar":["tabbrowser-tabs","alltabs-button"],"toolbar-menubar":["menubar-items"]},"seen":["abp-toolbarbutton","policeman-toolbarbutton","status4evar-legacy-widget","openwith-widget","openwith-widewidget","keefox-button","action-button--jid1-dgnibwqga0sibwjetpack-igtranslator","dirtyAreaCache":["PersonalToolbar","nav-bar","TabsToolbar","toolbar-menubar","PanelUI-contents","addon-bar"],"currentVersion":2,"newElementCount":0}

e-motiv commented 9 years ago

Confirmed: My keefox and Fastest search buttons were also on the address bar before and both disappeared. Now, I have put both of them on the bookmarks toolbar and they don't disappear anymore. Further on, I assume that one confirmation of it on a fresh profile from Alex9001 was enough.

P.S. Other add-on buttons on the address bar do nót dissappear, which are: SimilarSites, Auto-fill forms, Stylish I think that might help pinpointing the problem.

luckyrat commented 9 years ago

The icon scale looks correct - the key sticks out the side of the globe so the globe itself always looks a little smaller than icons that are simply circular or square.

I'm afraid I don't have any further ideas at this stage.

e-motiv commented 9 years ago

I don't understand your reply, luckyrat. Maybe the answer was directed at Alex (I only cross read his big comment), who has "smaller" icons, but for the record:

For me the buttons completely disappear (from both addons which have that problem), as in "gone from toolbar". I know that because when they disappears, they become available on the Customize -> "Additional tools and features" section (where all the non-used buttons reside) and are otherwise not there. Because of my testing together with other addon buttons (from both kinds, the ones which have that issue and which don't have that issue) I'm almost sure it has something to do with how the sdk button (creation) is coded. Might be just that tit different which makes firefox behave..buggy or weird in some cases and not in others. I dunno... (A "stay on bar when stretching happens" property? Now, I'm really throwing random ideas..:-) ).

luckyrat commented 9 years ago

@e-motiv yes, Alex mentioned that the scale of the icon was unusual so I just explained why - it's a red herring as far as diagnosing the disappearing button problem.

Firefox always keeps the add-on buttons on either the main toolbar or in the "more buttons" hamburger overflow menu. I think it would be possible for an add-on to remove itself from the toolbar and insert it back into the "customise" palette but I know KeeFox does not do that. Which leaves only three options: a bug in Firefox, a bug in one of your other add-ons (perhaps using the sdk in an unusual way as you suggest) or a fault with your Firefox profile (potentially caused by any bug in any addon/Firefox since you first installed Firefox). The best way to proceed would be to backup your Firefox profile and then use the Firefox reset functionality and re-install and re-configure each addon one at a time until the problem re-appears (hopefully never but if it does re-appear, it could be caused by any add-on installed up to that point, or a Firefox bug that only manifests itself on systems very similar to yours).

I hope you don't think I'm being dismissive of the problem but with 50,000+ daily users of KeeFox I think a fault as obvious as the button disappearing would be reported by more than a few people if it were something that KeeFox is doing wrong. I'm happy to investigate further if you can narrow down the cause to a conflict between KeeFox and a particular add-on (e.g. I can look at the other add-on's code and contact the author to try to get the problem fixed) but I need to be able to reproduce the problem from a clean Firefox profile in as few steps as possible.

e-motiv commented 9 years ago

No, I don't think you are being dismissive. I'm grateful any way. It was just in case you'd have an insight or something. I'll live with the workaround for now, until more people report it or they could find some time for reinstall and reset and such.

Take care!

luckyrat commented 9 years ago

For anyone who finds their disappearing button is ending up on the "more menu items" overflow hamburger button, there are some more suggestions in #349

konus1 commented 9 years ago

I had also the problem with the disappearing keefox button on both, my work and on my home pc. I think it is a bug in interaction with some other addons, I have installed. I already deleted "Evernote Web Clipper" but it was not the (only) solution. Unfortunately debugging is quite difficult, since it seems like it disappears randomly. I ended up moving the icon from addon area up to the tab bar and stopped debugging. sorry.