kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

Something is broken since 1.5.3 #539

Closed DominikStyp closed 8 years ago

DominikStyp commented 9 years ago

Previous version (1.4) works great, but last (from 1.5) has a bug which uses whole thread of my processor with no reason. Please fix that.

luckyrat commented 9 years ago

They are identical except for a few changes to text strings and the addition of the French language. Unless you are using an affected language this can't be caused by the upgrade to KeeFox (and even then it would be a Firefox bug if slightly different text can cause high CPU usage).

If you can reliably reproduce the issue after swapping back and forth between the two versions a few times, please report it as a Firefox bug. The only possible explanation that comes to mind is if their new addon signing process triggers a bug but even that seems incredibly unlikely so I would suggest looking for other reasons for this high CPU usage.

ilneroviaggiatore commented 9 years ago

HI, same issue. After upgrade to 1.5.3, very high CPU usage.

Thanks!

ilneroviaggiatore commented 9 years ago

Hi, i downgraded to 1.5.3 b1 and usage CPU is again correct and KeeFox work fine again for site where it usually worked fine for me.

luckyrat commented 9 years ago

Which site? On 15 Sep 2015 15:52, "ilneroviaggiatore" notifications@github.com wrote:

Hi, i downgraded to 1.5.3 b1 and usage CPU is again correct and KeeFox work fine again for site where it usually worked fine for me.

— Reply to this email directly or view it on GitHub https://github.com/luckyrat/KeeFox/issues/539#issuecomment-140418874.

ilneroviaggiatore commented 9 years ago

Hi, site are private tracker forum as http://www.bit-italia.org. But now also 1.5.3 b1, as newer one, has high CPU usage. I have again to remove KeeFox from extensions. I hope the problem will be resolved! Thanks!

luckyrat commented 9 years ago

I can't reproduce this, which is unsurprising since none of our 500 beta testers reported the problem so it must be pretty rare.

Those of you experiencing the problem will have to supply a lot more detail about the steps that you take to trigger the problem and information about your computer (O/S version, all other security software, Firefox addons, KeePass plugins, etc.). Hopefully that will then reveal some common cause of the problem.

Warlockbugs commented 9 years ago

Same issue. I also had problems with upgrading from 1.4.x to 1.5.x. It couldn't connect to my KP until i did both: i've upgraded KP2 to 2.30 and uninstalled Keefox, then installed Keefox again. The CPU usage goes sky high as soon as FF opens a new URL and then goes down when the page is fully loaded. But hey, at least, i've got it to work with my KP2.

FF Developer Edition x64, 42.0a2, 2015-09-15, Windows 10 x64, KeePass 2.30 portable.

Warlockbugs commented 9 years ago

Also, i forgot to add, e10s is enabled.

DominikStyp commented 9 years ago

Hi! Sorry, I was mistaken about downgrade version, now I see that problem disappeared after downgrade to last 1.4 version (1.4.8.1-signed), with all 1.5.x versions high processor usage persists. It doesn't matter which site I have opened in Firefox, because after browser start (or restart) CPU goes to 15% (full 1 thread usage) instantly. And I must add important info - it's independent to KeePass, because if KeePass is OFF or ON problem persists. My system: Win7 x64, Firefox 40.0.3

ilneroviaggiatore commented 9 years ago

Hi, problem there is even if before remove all of addons and then install only new KeeFox. From yesterday even after downgrade there is same problem of high cpu usage. My system: Windows XP SP3 Java 7.80 (build 1.7.0_80-b15) Avast Free Antivirus 10.3.2225

Thanks for the support!

general714 commented 9 years ago

Just to say, I have the exact same issue. I reckon that it's very common as I've had it on two different computers with different set-ups. Downgraded to 1.4.8.1 signed and it's back to usual. This is a GREAT add-on and works extremely well, but the new version maxes out CPU and therefore needs tweaking urgently. Windows 7 x64, Firefox 40.0.03

ilneroviaggiatore commented 9 years ago

Downgraded to 1.4.8 and it works fine.

dharkbizkit commented 9 years ago

Same problem. cpu usage instantly goes up to 32% the moment i start FF with KF and my ram starts to fill up, untill FF reaches 1gb. the longer i use the browser in that condition. the slower it get. after 1h keyboard imput takes 5 seconds to appear on the screen. problem apperently appeared over night, not directly after the update a few few days ago FF 40.0.3 (addons - anonymoX, ask for sanitize,disconnected,download status bar, down em all, ghostery,https everwhere,random agent spoofer, secure snaitize,uBlock, youbetube video and audio downloader) win 10 x64 avira Kp2 auto backup

some screens

without FF after starting without KF

restart and KF activated 5 seconds after starting up the browser secslater 30 secs after starting the browser fewsecslater

akava commented 9 years ago

Same on my PC. Downgraded to 1.4.8 which fixed the CPU consumption https://github.com/luckyrat/KeeFox/releases/tag/v1.4.8

Etuldan commented 9 years ago

Same as @akava , high CPU usage with current version, downgrade is OK. I use French locales on my computer (OS & Firefox) Win7 64.

bege10 commented 9 years ago

CPU usage over 50% with KeeFox 1.5.3, even with only one empty tab, normal with v1.4.8

Windows 7 Professional 64 bit SP1 (German) Firefox 40.0.3 (German) Security programs: Windows firewall, 360 Total Security (anti-virus)

luckyrat commented 9 years ago

When you see the high CPU usage, is KeeFox connected to KeePass? E.g. can you search the KeeFox main panel for results from KeePass?

Etuldan commented 9 years ago

KeeFox is connected to KeePass when there is High CPU usage. (I didn't try the search, but the autocompletion of fields was ON (without "autotype", ofc))

Warlockbugs commented 9 years ago

Unfortunately, i've seen high usage even when my Keefox had issues with connecting to KeePass 2. I can't reproduce these issues anymore. The CPU usage goes high as soon, as a new tab or page is loaded, and the website is referenced in one of the entries in KeePass 2 database. On github in particular, when i open "sign in" page, firefox nearly hangs for about 5-10 seconds, before rendering the page. The keefox icon goes from blue to gray (as if it was disconnected from keepass) for a mere fraction of second before changing to blue-plus icon (i.e. matched entries found for the website). On a cold start, firefox shows standard "script takes too long to execute" notice on the last open webpage (i.e. when loading previous session).

luckyrat commented 9 years ago

Does it indicate which "script takes too long to execute"?

Warlockbugs commented 9 years ago

No, clicking "debug" does nothing. I think its glitched. I'll try my best to get as much more info as possible next time i see this pop-up notice.

ilneroviaggiatore commented 9 years ago

Re: "When you see the high CPU usage, is KeeFox connected to KeePass?" Yes, when i see the high CPU usage, KeeFox is connected to KeePass.

bege10 commented 9 years ago

Here it doesn't matter whether KeeFox is connected to KeePass or not. As soon as Firefox is started I have the high CPU usage with KeeFox 1.5.3 (see my post above)

Windows 7 Professional 64 bit SP1 (German) Firefox 40.0.3 (German) Security programs: Windows firewall, 360 Total Security (anti-virus)

luckyrat commented 9 years ago

I'm afraid I still can't see anything wrong, nor any clear pattern from the information supplied so far.

Can someone experiencing the problem please create a completely new Firefox profile, leave all settings at their defaults and ensure every plugin (e.g. flash, java, antivirus, etc.) is disabled and then install KeeFox to see if the problem occurs again?

Warlockbugs commented 9 years ago

I've been trying to catch which script stalls the FF, but without any luck. It doesn't point to any script or targets random scripts without any specific pattern,

Warlockbugs commented 9 years ago

Update: I don't have any CPU usage issues on a fresh profile in Firefox Developer Edition 42 with Keefox as the only installed addon. I do receive strange message when linking to KeePass: "This version of Keefox (1.4.4) is older than the installed KeePassRPC plugin (1.5.3)." Both KeePass and Keefox are up-to-date, obviously. I'll try to perform a full profile wipe and reconfigure all addons from the ground up (this will take ages :( ) on weekend.

Warlockbugs commented 9 years ago

I beg your pardon for notification spam, but i've got another update: Disabling e10s on the old profile has the same effect as creating a new profile (where e10s was probably disabled by default). The issue lies somewhere within e10s compatibility.

luckyrat commented 9 years ago

Does everyone with this problem have e10s enabled?

I do too so it's not incompatible but maybe there is an e10s related Firefox bug on some hardware platforms?

"This version of Keefox (1.4.4) is older than the installed KeePassRPC plugin (1.5.3)."

This only gets displayed when you have an old version of KeeFox installed but if you have session restore enabled I think it's possible for the old information to be displayed after you restart Firefox. It will go away once you close the tab (unless you really do have an old version of KeeFox installed).

bcutter commented 9 years ago

Same here on Win7 x64 with KF v1.5.3. firefox.exe consumes appr. 13-14 % (on a 8 core cpu). Took a time to track it down to KeeFox, but it´s definitely KF. Disabled addon. Problem gone. Enabled again. High CPU usage back. Doesn´t matter if KP is running and/or if KF is connected to KP; as soon FF is running KF is consuming the CPU usage.

KF v1.5.3 KP v2.30 KPRPC v1.5.3

Please keep working on this and provide a fix! It´s really horrible to use FF this way.

Downgraded now to v1.4.8 and disabled automatic update for KF-addon -> everything working smooth again, no noise from cpu fan.

luckyrat commented 9 years ago

Please keep working on this and provide a fix! It´s really horrible to use FF this way.

If I discover that this is a problem with KeeFox I will definitely treat it as the top priority for a fix. However, as I explained above, I am currently not able to work on this since the problem affects only a small number of computers so all I can offer is a keen eye on this issue in case I spot any patterns regarding particular configurations or 3rd party software - unfortunately most people's comments do not contain enough information to make this possible.

Downgrading is obviously a good option for the time being but it is only a matter of weeks or months before those earlier KeeFox versions stop working with the latest Firefox version so I would prefer to have identified the cause of the problem before you are all forced to upgrade again. Since the problem is unlikely to be with KeeFox itself, it is even more important to work out the cause quickly so that Mozilla or other involved 3rd parties have enough time to fix it.

bcutter commented 9 years ago

unfortunately most people's comments do not contain enough information to make this possible.

How can I / can we help? What information do you need in detail?

luckyrat commented 9 years ago

From my earlier but disparate comments:

Those of you experiencing the problem will have to supply a lot more detail about the steps that you take to trigger the problem and information about your computer (O/S version, all other security software, Firefox addons, KeePass plugins, etc.). Hopefully that will then reveal some common cause of the problem.

Does everyone with this problem have e10s enabled?

Can someone experiencing the problem please create a completely new Firefox profile, leave all settings at their defaults and ensure every plugin (e.g. flash, java, antivirus, etc.) is disabled and then install KeeFox to see if the problem occurs again?

Essentially we're looking for any Firefox configuration setting, 3rd party software, operating system configuration or hardware that is common for those people that experience the problem.

PS: Mozilla have now confirmed that KeeFox 1.4.x will definitely no longer work in Firefox 44 onwards (due out in January 2016).

ymym commented 9 years ago

I started using keepass 2.30 portable today and installed keefox 1.5.3 I really like this addon but yes, it uses 30% of my CPU which makes using it too hard.

UPD: i deleted all keefox files from keepass folder and deleted keefox plugin from FF, then i installed 1.4.8 to FF and connected it to keepass -- it seems to be ok, all works and i'm almost happy. Maybe we (who have problems with CPU usage) should use 1.4.8 ? Why upgrade?

And one more thing. We have 15 mailboxes on our computer. When we open mail site keefox offers only 5 logins to use and for other 10 user have to click a "more entries" button and scroll in this list because it shows only 8 entries. Pls make keefox to show all 15 entries without any other buttons. regards

dot-nom commented 9 years ago

Hi This problem seems to interfere it with other Addon. I installed Win7x64(Japanese) on VMware and tried it on a completely new Firefox profile. CPU utilization rose when I installed only A and B. A=KeeFox 1.5.3 B=AnonymoX 2.5.2 In the case of the version that is old in either one, CPU useage is not rise up. C=KeeFox 1.4.8.1 D=AnonymoX 2.4.6.1 So now I use of A & D in combination it.

luckyrat commented 9 years ago

So here's another question for everyone affected: Do you use a proxy server (or an add-on like AnonymoX which enables a proxy server on your behalf)?

dot-nom commented 9 years ago

I do not introduce the proxy-related thing at all any place other than AnonymoX.

Malachiel87 commented 9 years ago

got the same issue, on windows xp, keefox make firefox use 100% cpu on my windows 7 no issue.. i dont' use proxy thing

luckyrat commented 9 years ago

Not sure about everyone else's situation, but it looks like AnonymoX is at fault for @dot-nom

I don't know exactly what it's doing but inspecting what slows down Firefox when it's installed points squarely at its code (jquery in particular) and I can't see any indication of KeeFox being involved. That KeeFox is implicated by being installed too indicates that the addon is doing something very slow with every network request made through your browser (even when the add-on is disabled it is not cleaned up until after a Firefox restart which is a big red flag for me). The warnings of adverts being injected into pages is a pointer towards the cause of the problem (maybe it does something slow every time just to try to work out whether it should insert an advert and the exceptionally slow performance every few seconds might be it trying to inject an advert to KeeFox's communication with KeePass?)

I reiterate that everyone experiencing potential performance problems with KeeFox should triple check that there is no malware or otherwise network-interfering software installed on your machine - I'm sure it's not the only possible cause of the problems and I'm not sure why the upgrade to v1.5 would change the behaviour but it's definitely a possibility worth checking carefully.

ymym commented 8 years ago

i checked my system with antivirus and antimalware softwares and nothing was found.

Keefox updated today from 1.4.8 to 1.5.3 without any requests and started to use 30% of my CPU.

It's not cool, how can i make it unupdatable? I don't need 1.5.3 if it slows down my PC, i want 1.4.8 ))

luckyrat commented 8 years ago

Since I'm suspicious that there are malfunctioning proxies involved somewhere, please can someone with the problem provide a KeeFox Debug log of a roughly 10 second period where the problem is occurring? That might confirm (or reject) a theory that a malicious or faulty proxy is constantly forcing KeeFox to attempt reconnection to KeePass faster than it normally would. It still doesn't quite add up but since connection establishment is the only significant bit of CPU heavy work KeeFox does and there are implications above that a proxy might be involved, it at least warrants gathering some further data.

luckyrat commented 8 years ago

how can i make it unupdatable?

You should be able to do that in the Firefox add-ons config screen (click the "more" link to find the Firefox option specific to updating KeeFox).

I don't need 1.5.3

As I said a couple of posts earlier, this might be true but only for a short time. Firefox 44 will definitely not work with versions earlier than 1.5.3 (so January is a definite cut-off point but of course Mozilla might do something to break 1.4.8 before then so there are no guarantees you'll even get those 3 months of use)

akava commented 8 years ago

No proxy installed in my FF. CPU consumption is high no matter if KeePass unlocked or not. Collected DEBUG logs for 40 secs or so. Will send it privately. We can catch up by Skype to debug the problem

luckyrat commented 8 years ago

Thanks @akava. I've looked at the log and don't see the behaviour I was interested in seeing (continuous attempts to reconnect to KeePass or large-scale repeated data transfer with KeePass). In fact, there is nothing immediately unusual about your log except for the large periods of time between some log statements Deleting any references to login data for recently completed async find logins call. seems to precede at least 10 seconds of nothing happening. This might be perfectly normal behaviour based upon your interaction with the browser and KeePass or it might indicate that Firefox was too busy during that period to actually allow KeeFox to do anything. I'll try to investigate that in more detail at the weekend.

In the mean-time, I'm wondering if you would be able and willing to provide a performance log from Firefox for me to analyse? I think it would require running Firefox Nightly or at least Firefox Developer Edition. I'm going to test out the process of sharing this performance data today before writing up instructions on how to do it.

akava commented 8 years ago

it might indicate that Firefox was too busy during that period

No, FF was not busy. I was clicking around the page.

if you would be able and willing to provide a performance log from Firefox for me to analyse

sure, if you tell me how to do that and how to collect the logs

luckyrat commented 8 years ago

sure, if you tell me how to do that and how to collect the logs

  1. Open the Browser Toolbox by following the instructions described here: https://developer.mozilla.org/en-US/docs/Tools/Browser_Toolbox
  2. Then go to the Performance tab
  3. Click "Start Recording"
  4. Wait 30 seconds (try to avoid doing anything else in Firefox at the same time)
  5. Click "Stop Recording"
  6. On the left there will be a "Recording #1" section
  7. Click the "Save" link in that box and put the "profile.json" file somewhere.

It should be small enough to email but feel free to post elsewhere for me to download if you prefer.

Thanks!

ymym commented 8 years ago

maybe we can connect on skype and you will see what's wrong and why CPU usage is so high?

luckyrat commented 8 years ago

@akava It looks like the cause of your slow Firefox is a Youtube download add-on. As you can see from the reviews, it attracts similar criticism as AnonymoX in terms of intercepting network requests in order to occasionally insert advertising: https://addons.mozilla.org/en-GB/firefox/addon/1-click-youtube-video-downl/reviews/

The failure mode appears to be identical to AnonymoX in that both add-ons include the jQuery Javascript library and both get stuck in some kind of loop causing jQuery's timer functionality to run out of control.

I'm still not sure what might have changed in KeeFox 1.5 to trigger the bugs in these other add-ons but uninstalling the faulty add-on should make Firefox performance go back to normal. Let me know if not, just in case there is more than one problem contributing to the high CPU usage.

Malachiel87 commented 8 years ago

I confirm that i unistalled that plugin and upgraded keepfox, now it work fine!

Il 17/10/2015 13.18, Chris Tomlinson ha scritto:

@akava https://github.com/akava It looks like the cause of your slow Firefox is a Youtube download add-on. As you can see from the reviews, it attracts similar criticism as AnonymoX in terms of intercepting network requests in order to occasionally insert advertising: https://addons.mozilla.org/en-GB/firefox/addon/1-click-youtube-video-downl/reviews/

The failure mode appears to be identical to AnonymoX in that both add-ons include the jQuery Javascript library and both get stuck in some kind of loop causing jQuery's timer functionality to run out of control.

I'm still not sure what might have changed in KeeFox 1.5 to trigger the bugs in these other add-ons but uninstalling the faulty add-on should make Firefox performance go back to normal. Let me know if not, just in case there is more than one problem contributing to the high CPU usage.

— Reply to this email directly or view it on GitHub https://github.com/luckyrat/KeeFox/issues/539#issuecomment-148908095.

luckyrat commented 8 years ago

Please can anyone still experiencing this problem follow the instructions above to get a performance log. I'm particularly interested to get logs from those who have seen this problem despite having no other add-ons installed.

The log could contain URLs of website's you have opened in your current session so I recommend zipping it up (compressing) and sending it to me privately (put my username in front of an @ and musites.com).

Thanks for the offers of Skype debugging but I don't have Skype at the moment and think that any debugging would be pretty aimless and time-consuming for both of us given the current information available (that might change of course). CC: @ymym

PS: Glad to hear it @xion87 :-)

Warlockbugs commented 8 years ago

@luckyrat Thanks for pointing towards the potential source of the problem! I've browsed through my addons in search for JS-related addons and found another culprit: https://addons.mozilla.org/en-us/firefox/addon/canvasblocker/ I've disabled it and now it works fine in e10s mode again. Strangely enough, this performance issue only pops up in e10s mode, so disabling e10s may be a suitable temporary alternative to uninstalling/disabling addons.