search

kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

KeeFox installs KeePass even there is one running #59

Closed luckyrat closed 11 years ago

luckyrat commented 11 years ago

I have KeePass installed into different location rather than "C:\Program Files". KeePass is running at the moment I install KeeFox addon.

Current behaviour: KeeFox downloads new KeePass installation & installs it.

Expected: KeeFox detects the KeePass location and installs KeePassRPC.plgx plugin to existing KeePass location. If installation failed, ask user to close KeePass and retry [or] extract plugin to some directory and ask the user to install plugin manually.

If KeeFox depends on some particular KeePass version (say, >= v2.12), KeeFox should suggest the user to upgrade, but do not do it automatically.

KeeFox v0.77.

luckyrat commented 11 years ago

_Imported from trac issue 47. Created by dmak on 2010-07-19T11:57:00, last modified: 2011-03-28T22:50:16

luckyrat commented 11 years ago

Trac comment by luckyrat on 2010-08-01 17:43:15:

Quite a few different issues involved here so I'll list out the main points:

1) KeeFox can't detect that KeePass is running until KeePassRPC is installed and running; since that would negate the need for any setup anyway, the installation process cannot make any attempt to detect "running" KeePass installations. Any installation via the standard KeePass setup executable should be detected correctly.

2) KeeFox does download the latest KeePass installation file - I have almost implemented code to cancel that download when it is not actually required but a bit more work is required.

3) Clicking on the advanced setup options allows a way for you to choose an existing KeePass location but I have heard of other problems that make me suspicious that this feature is not working - it's already on my list of things to improve before 0.9 is released.

4) The setup process needs a bit of work on the user interface to make it clearer what is going on and that is also something I want to work on before 0.9 is released.

5) KeeFox depends on KeePass version 2.10 but makes no attempt to detect the KeePass version (again, this is impossible unless KeePassRPC is running, which would imply that KeePass is already new enough!). If the setup process completes and it turns out that KeePass is too old, there is a standard KeePass message that will inform the user about that problem which can then be resolved independently of any of KeeFox's setup procedure.

Thanks, Chris

luckyrat commented 11 years ago

_Trac comment by dmak on 2010-08-03 14:12:14:

I agree that for mozilla plugin the list of current processes might not be available. maybe plugin can query system registry?

My major point is that there should be a way to prevent KeeFox to download KeePass on e.g. addon upgrade. Maybe ask question "Do you have KeePass installed", if yes, then as for KeePass location and install KeePassRPC plugin to that location.

luckyrat commented 11 years ago

Trac comment by luckyrat on 2011-03-10 00:37:47:

Sorry for the delay getting around to this task. I've just had a look at the setup procedure and made a lot of improvements. Points 2 and 3 above should now be working as expected and point 4 has also seen what I hope is enough attention to make the setup process clear enough for a final 1.0 release.

For your specific issue, I suspect that the initial setup screen interface did not make it clear enough that you could use the "advanced setup" options rather than just clicking straight through to "setup keefox". Please can you try a fresh installation with [http://keefox.org/download/experimental-version KeeFox 0.8.8] and have a think about how the initial screen can make this option clearer?

I should emphasise that my primary aim for this setup routine is to provide a low barrier to entry for those people that are unfamiliar with KeePass (and computers in general) but of course, if it is at all possible, I do not want to complicate matters for existing KeePass users! Your feedback would be most welcome here or preferably on [https://sourceforge.net/apps/phpbb/keefox/viewtopic.php?f=1&t=108 this forum thread] that I have created in the hope that the discussion is more widely visible to interested people. I have addressed your "do you have KeePass installed?" suggestion on that thread.

To (belatedly) answer your question, the KeeFox add-on does query the windows registry. It should therefore find any KeePass 2 installation that was installed using the .exe or .msi installer. Perhaps this is / was broken? If you think your KeePass installation was through one of these methods and KeeFox 0.8.8 is still unable to detect its installation location then please reply to this ticket to let me know.

If it does transpire that the main issue is one of user interface design then I will close this ticket and continue the discussion on the forum as previously noted. If / when we can work out a suitable change to the installer that reduces the chance of this issue being raised again then we can add it as a new feature request ticket.

Thanks, Chris

luckyrat commented 11 years ago

_Trac comment by dmak on 2011-03-16 21:34:55:

Plugin upgrade to v 0.8.8 went smoothly. It looks like I've overlooked the "advanced" options, but plugin installation went fine without my involvement anyway. The installation process asked to close KeePass and after the plugin was updated, KeePass was started automatically. Looks like a top of my dream... Perfect.

luckyrat commented 11 years ago

_Trac comment by thasun on 2011-03-26 23:09:04:

This did not happen to me with a fresh installation of the latest KeePass and KeeFox on Firefox 3.6/Win64. KeePass was active and running though - not sure whether the OP meant this, or whether KeePass was merely installed, but not running.

However, clicking on the KeeFox setup did nothing except of executing the RPC handler. In order to complete the KeeFox setup, I had to close the running KeePass instance and "try again". Will file a separate issue for that.

luckyrat commented 11 years ago

_Trac comment by dmak on 2011-03-27 13:00:04:

I was testing the installation with closed KeeFox. I don't remember right now: was there any message that KeeFox need to be closed before continuing with installation?

luckyrat commented 11 years ago

Trac comment by luckyrat on 2011-03-28 22:50:16:

Since the new ticket is more relevant for these later comments, I'm closing this one and have responded on #84

Thanks, Chris