search

kee-org / KeeFox

Legacy browser and XUL application integration with KeePass Password Safe. See https://github.com/kee-org/browser-addon for the new version for Firefox 57+
https://forum.kee.pm
418 stars 48 forks source link

NewChannelFromURI deprecated #795

Closed hackel closed 4 years ago

hackel commented 7 years ago

I noticed that my browser console was filling up with thousands of these messages every second:

Warning: 'nsIOService::NewChannelFromURI()' deprecated, please use 'nsIOService::NewChannelFromURI2()' session.js:273:38

I saw the note in the source about "some kind of extra secret parameters" and decided to take the time to try to figure it out. This appears to be working fine:

let principal   = Cc["@mozilla.org/systemprincipal;1"].createInstance(Ci.nsIPrincipal);
rpc.httpChannel = ioService.newChannelFromURI2(
    uri,
    null,
    principal,
    principal,
    Components.interfaces.nsILoadInfo.SEC_REQUIRE_SAME_ORIGIN_DATA_INHERITS,
    Components.interfaces.nsIContentPolicyBase.TYPE_DATAREQUEST
);

I'm pretty much guessing here, but everything seems to work. KeeFox detects when KeePass is running and can fill out passwords, etc.

github-actions[bot] commented 4 years ago

Following the recent announcement of the end of critical security patch support for this old software - https://forum.kee.pm/t/keefox-critical-security-support-ends-30th-september-2020-kee-is-unaffected/3219 - this issue has been automatically marked as stale. We will soon close this issue and then archive this repository in early October 2020.

If you think that the issue contents may still be relevant to the actively maintained Kee project, the successor of KeeFox, please search the community forum for help and post a new topic if appropriate: https://forum.kee.pm

Please do not reply to this comment / notification - it won't be seen.