search

kee-org / browser-addon

Kee adds free, secure and easy password management features to your browser which save time and keep your private data more secure.
https://www.kee.pm
Other
453 stars 41 forks source link

Kee freezes Firefox #27

Closed NoXPhasma closed 7 years ago

NoXPhasma commented 7 years ago

Kee freezes Firefox completely on Tab change or when I open a new Tab. It doesn't matter how long I wait, Firefox does not come back to live. I need to hard kill Firefox.

When I disable Kee there is not a single freeze of Firefox at all. I still need to find out if this is related to using Kee to fill out forms or if it just happens when it's finding compatible forms. But I can say that it doesn't happen all the time I'm using Kee, which doesn't make it easy to reproduce.

edit I think I can say it's unrelated to using Kee actively. But when it freezes, it is on Tab change/close/new Tab when the last used page has a form.

akuntsch commented 7 years ago

I experienced the same problem. Ever since I disabled Kee the freezes are gone. I'm on the same versions on Windows 10.

luckyrat commented 7 years ago

I've not been able to reproduce on a few recent nightly versions. I think I skipped any that were released on 20170906 so maybe the bug is only in that version? Do you see the problem still?

I tried to repro by opening a new window and loading two tabs that contained login forms on different sites which Kee had matching logins for. I then held down ctrl-tab to cycle between the two as fast as possible. I also tried fast mashing of ctrl-tab and f5 to put some page refreshes in there.

akuntsch commented 7 years ago

For me the freezes only happened sporadically, a few times a day I'd say. Most of the time when opening a new tab.

I just enabled the Kee add-on again and will see if it still happens.

NoXPhasma commented 7 years ago

I've enabled Kee with the newest Nightly again and Firefox froze right away :D

However, I wasn't able to bring it to freeze while changing tabs right now. Will keep an eye on it and report if it will freeze again.

luckyrat commented 7 years ago

Any idea if this problem started as soon as you started using alpha 5?

NoXPhasma commented 7 years ago

I'm not really sure about that, sorry. Nightly gets 2 updates a day now, which makes it harder to recognise if a bug was introduced in a Nightly update or by an Addon.

luckyrat commented 7 years ago

It does seem odd that Firefox can freeze entirely. I thought all aspects of WebExtensions were in isolated processes so that this couldn't happen. Hmmm... well, any further info you can find over the coming days would be helpful whether we need to report a Firefox bug or just make a change to the way Kee uses some of the APIs.

NoXPhasma commented 7 years ago

Yes, that makes me wonder too how this even happens. One process consumes 100% load on a thread when it happens, next time I will look into the system monitor to find out if it's the Firefox process itself which hangs, or a Firefox subprocess ("Web Content" on Linux).

I will report anything I can find which might help finding the cause.

NoXPhasma commented 7 years ago

It just happened again, when I opened a link in a new Tab with my middle mouse button. That website don't have a login form where I opened the link, but the page which opened in a new Tab has a submit form.

I can't reproduce it when doing the same again, tried it several times.

The process which consumes one thread is Firefox, so the Addon freezes the Browser itself, not a subprocess.

NoXPhasma commented 7 years ago

I got a Nightly update and now Firefox freezes right at the start of the Browser. When I disable Kee, Firefox starts fine again.

I've started Firefox on the console but there was no output, usually Firefox is very verbose. I would like to go deeper, but I have absolutely no idea how I could get more data about what is going on.

luckyrat commented 7 years ago

Do you have session restore enabled? I wonder if the update to the new nightly is coincidental and that actually there is something about one of the pages in your previous session which is now triggering the bug earlier. I think session data has moved recently so I'm not sure how feasible it is to explore or modify it on the file system in order to diagnose further.

On the plus side, it sounds more reproducible now, but then again, it was nigh on impossible to debug Firefox startup bugs last time I tried so we probably need the Firefox devs to help out.

On 8 Sep 2017 04:15, "NoXPhasma" notifications@github.com wrote:

I got a Nightly update and now Firefox freezes right at the start of the Browser. When I disable Kee, Firefox starts fine again.

I've started Firefox on the console but there was no output, usually Firefox is very verbose. I would like to go deeper, but I have absolutely no idea how I could get more data about what is going on.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/kee-org/browser-addon/issues/27#issuecomment-327988017, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJ77_cwOZ7dAFgvLWMz-j9ACvrA2L_Wks5sgLFWgaJpZM4POAhK .

luckyrat commented 7 years ago

Do you see the problem when KeePass is not running?

Maybe if you both "copy text to clipboard" from the data shown in about:support and attach it here, it could help us spot a pattern?

Can you try installing Kee into a new Firefox profile and seeing if the same problem occurs?

akuntsch commented 7 years ago

I actually created a new profile because I thought this issue was caused by my old profile, but it still happened on the new profile.

I will try withot KeePass running.

My about:support output: https://gist.github.com/akuntsch/02cd391fd86d4620bcc056eb179eb73a

akuntsch commented 7 years ago

And it just froze again when opening a tab without KeePass running

NoXPhasma commented 7 years ago

about:support: https://gist.github.com/NoXPhasma/ae09958c4d98abd76adff5e3a1dade6c

I haven't tried to run Kee without having KeePass running, but doing now. It's running for around an hour without an issue. Will keep it running and eventually start KeePass to see if it changes anything.

I will also try to run Kee in a new profile, probably tomorrow.

NoXPhasma commented 7 years ago

It just happened without having KeePass running and since this happens to @akuntsch too, I guess it's save to say that it doesn't has anything to do with KeePass.

NoXPhasma commented 7 years ago

Just created a new profile, installed Kee and it took only 3 minutes and some Tab changes till it froze the Browser.

Kee was the only Addon installed and I haven't changed anything on the Firefox settings.

luckyrat commented 7 years ago

https://github.com/kee-org/browser-addon/releases/tag/2.0.0-a6 fixes a couple of possible startup bugs. I can't see how they relate to these freezing problems, but since I can't reproduce them on my system anyway it's difficult to know what else to try.

I've tried new profiles and compared my about:support output to yours with no notable differences found. I also can't reproduce in Chrome. If these long-shot changes in alpha 6 don't help, it's hard to see this is anything other than a Firefox bug :-(

NoXPhasma commented 7 years ago

2.0.0.6 doesn't freeze Firefox on launch anymore. Now let's see if it also stops the freeze on Tab change.

akuntsch commented 7 years ago

No freezes with 2.0.0.6 yet. Seems to have fixed the issue.

NoXPhasma commented 7 years ago

Same for me, haven't had a single freeze since I've installed 2.0.0.6.

NoXPhasma commented 7 years ago

After many hours without any issue, it just happened again, but it seems to be less frequent than before.

Interesting is, I was watching a video when I tried to change the Tab, then Firefox froze but the video was still running. Not only audio, but the video itself was running and I could watch it. So it seems that not really the whole browser freeze, but the interaction with the browser is broken then.

akuntsch commented 7 years ago

I had a single freeze on 2.0.0.6 as well. It's definitely much better than 2.0.0.5 though.

andreicristianpetcu commented 7 years ago

Please report a bug in Firefox. Regardless of how WebExtension APIs are used, they should not be able to freeze the browser.

I don't know enough about this issue to report the bug.

Dimas-sc commented 7 years ago

Same here! It happens to me since first installed Kee alpha version but I thought the problem was from Firefox and I reported this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1398099 There you can find some related information.

I updated to Alpha 8 and it happens yet. Every time it happens a crash report is reported. Example: https://crash-stats.mozilla.com/report/index/343fd453-b6e2-45ec-aa59-020050170929

luckyrat commented 7 years ago

I've commented on the Firefox bug @Dimas-sc created. If anyone else has any information to add to help point the Firefox devs towards a solution that would be much appreciated.

gbil commented 7 years ago

I'm able to reproduce with both 2.0.0.6 and 2.0.0.8 . What happens is that firefox is in general unresponsive, if I go into task manager I see one firefox process using 25% of the cpu (4 cores so it's using 100% one core) and if I kill that process firefox continues just fine without affecting the open tabs. If I disable kee extension I never get this behavior.

NoXPhasma commented 7 years ago

I'm running Kee version 2.0.0.8 with current Nightly (48.0a1) without any freeze for two days now.

NoXPhasma commented 7 years ago

I guess I jinxed it. 2 days without any issue and just became an update and Firefox freezes on every start when Kee is enabled.

luckyrat commented 7 years ago

just became an update

A Firefox update?

If so, please can you post the information about the build that this behaviour changed in to https://bugzilla.mozilla.org/show_bug.cgi?id=1398099 ? And ideally the build that you were on beforehand.

If you mean a Kee update, please confirm which version you upgraded to.

NoXPhasma commented 7 years ago

Sorry that I wasn't explicit enough, I've got a Firefox update (Build id 20171009100134). I've got several Firefox updates the last days and Kee was working, then yesterday evening another Firefox update came and then it froze again.

I've answered to the bug report.

Dimas-sc commented 7 years ago

Happened again with Kee a12 and the last Firefox 57 beta

Larusek commented 7 years ago

I ack this bug with latest 58.0 Nightly and Alpha 12. After some time entire Firefox hangs with max. cpu usage.

czolgandrzej commented 7 years ago

Still freezes, alpha13 on 57.0b6 (64 bits). I've got this error messages on about:debugging

https://i.imgur.com/6WWNJRQ.png

robsonsobral commented 7 years ago

With me, Firefox doesn't freeze, but stop to transfer. All HTTP activity stops!

cypressious commented 7 years ago

I'm seeing the same as @robsonsobral. It mostly happens right after booting up the PC and starting FF for the first time. I'm on Windows 10 64 bit.

robsonsobral commented 7 years ago

Running Windows 10 64bits too.

Sadly Kee doesn't work on Mac without tricks. I can't test it.

czolgandrzej commented 7 years ago

@robsonsobral : You're description is correct. It stops all http activity (ie cant reload tab or load new page). What is quite funny that mozilla addons online page works :)

NoXPhasma commented 7 years ago

What is quite funny that mozilla addons online page works :)

This is because WebExtensions don't work on addons.mozilla.org.

czolgandrzej commented 7 years ago

Its getting better and better :) Do you know why?

NoXPhasma commented 7 years ago

Yes, this is a security feature in Firefox to prevent addons from changing the addons page (i.e. deliver infected addons).

robsonsobral commented 7 years ago

@czolgandrzej , I can open new tabs or type a different URL on address bar, but nothing is rendered.

czolgandrzej commented 7 years ago

That's what I admitted :)

cypressious commented 7 years ago

So are we talking about two different issues here? One freezing Firefox and one where no site is loaded anymore?

Dimas-sc commented 7 years ago

When I was talking on 'freezing' I meant that no site is loaded anymore

cypressious commented 7 years ago

What about the original report by @NoXPhasma?

NoXPhasma commented 7 years ago

For me Firefox isn't responding at all, which means I can't even switch tabs or access the addressbar. So I would say this are two different issues.

cypressious commented 7 years ago

Ok, I've created #38 where we should discuss the "not loading pages" part. This issue can be about FF hanging and and high CPU usage.

Larusek commented 7 years ago

I think that's one bug. Both issues are bound together. When one doesn't have multiprocess (e10s) it's simple that entire Firefox will freeze. High cpu load is always I guess (depends on cpu cores amount).

NoXPhasma commented 7 years ago

When one doesn't have multiprocess (e10s) it's simple that entire Firefox will freeze.

I do have e10s enabled and also can reproduce the freezes in a clean profile with only Kee installed. It's not as easy as to say that it would only freeze without e10s.