search

kee-org / browser-addon

Kee adds free, secure and easy password management features to your browser which save time and keep your private data more secure.
https://www.kee.pm
Other
453 stars 39 forks source link

CTA to unlock KeePass from the Kee main panel #99

Closed tleepa closed 5 years ago

tleepa commented 6 years ago

At this moment, if the KeePass database is locked, the icon in the browser says "OFF" and I have to go to KeePas, unlock the database and then Kee can fill the login forms.

Is there a way to unlcok KeePass database from the browser? Some additional action on the toolbar icon/context menu?

PS. I am using Fx nightly: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:59.0) Gecko/20100101 Firefox/59.0

luckyrat commented 6 years ago

ctrl+shift+2 works. Probably worth us adding a button to the main popup menu panel though.

Need a new string: "Login to password database".

Easiest approach is probably to add a new item to the menu list in the panel but I'm open to discussing alternative designs that might pull this call to action closer to the information section displayed at the top of the panel.

Needs to be enabled when the "OFF" label is orange.

Need to check what happens when there is no locked database and no record of most recently used database within Kee - I'm not too fussed whether it triggers an open dialog in KeePass or uses KeePass' own idea of recently used database but I think it should do something.

vbojan commented 5 years ago

After a long search I found this page as I've been looking for the same feature. It's quite cumbersome to frequently switch to KeePass to unlock it and minimize as it locks after a short period of inactivity :(

Ctrl+Shift+2 does exactly what I need and I was not aware of it after using KeeFox and Kee for a while. Additional search pointed to this page which I had no idea it existed: https://github.com/kee-org/KeeFox/wiki/en-%7C-Tips-%7C-Keyboard-shortcuts It would help other if Wiki page is referenced on https://www.kee.pm/ and in projec's README.md as many GitHub projects don't use Wiki and it might not be obvious to give it a try if there's no explicit reference about documentation (I knew about https://forum.kee.pm/t/installing-kee-instructions/23 and assumed Wiki pages were for developers only - my fault for not checking it earlier).

It would be nice to have configurable option to trigger the same functionality by simply clicking the Kee button when "OFF" label is orange as opening the main popup menu panel isn't very useful while KeePass is locked anyway. In case someone prefers to do it from the menu by clicking the new button they can enable/disable the configuration option to click the icon or add additional button in the menu when needed (orange "OFF" label).

If sometime in the future a feature to launch KeePass is added this can be extended to work with https://github.com/kee-org/browser-addon/issues/23

rjt commented 5 years ago

CTRL+ALT+K Will bring the main keepass app to the foreground.

luckyrat commented 5 years ago

This will be supported in Kee v3.1.

There are three states for the password manager to be in from Kee's perspective:

1) Not connected 2) Connected but no open databases 3) Connected with open databases

Kee Vault is tightly integrated to the web browser and thus can support an open/unlock button in all 3 states. For the time being the Kee Vault tab will remain focussed after the button is clicked in any state. Eventually we'll aim to detect a successful sign-in/unlock operation and automatically return focus to the tab that was active when the button was clicked.

For KeePass, the existing functionality in KeePassRPC can only support (2). A forthcoming version of the plugin will add support for (3). (1) might not be possible but if there is a way, it will depend upon #23 being implemented first. Focus will remain with KeePass for (3) and return to the browser for (2) and (1), although this behaviour can't be guaranteed on all devices and may change as devices get updated, etc.