Rotated Choc Key Placement is Wrong

[csteamengine]

Hello! I have been attempting to use this generator to produce a plate for my split keyboard but the thumb keys are not coming out properly.

After running my keyboard through here with choc spacing (18mm x 17mm), the two thumb keys are only 17.75mm apart, and the further right key is 0.433mm off from the bottom of the switch.

I have attached pictures of the dimensions that come out wrong and what the keyboard is intended to look right.

Please let me know if I'm doing something wrong on my end too, that would be very helpful.

Thanks!

P.s. This issue is also present in AI03's plate generator.

[csteamengine]

The switches are in the correct location in KiCad but the right thumb cutout is about .5mm off in both it's relative axes.

[nooges]

Can you paste your raw KLE for reference?

[csteamengine]

[{x:4.5,a:7},"\n\n\n\n5"],
[{y:-0.75,x:3.5},"\n\n\n\n4",{x:1},"\n\n\n\n6"],
[{y:-0.75,x:6.5},"\n\n\n\n7"],
[{y:-0.75,x:2.5},"\n\n\n\n3"],
[{y:-0.75},"\n\n\n\n1",{w:1.5},"\n\n\n\n2",{x:2},"\n\n\n\n12"],
[{y:-0.75,x:3.5},"\n\n\n\n11",{x:1},"\n\n\n\n13"],
[{y:-0.75,x:6.5},"\n\n\n\n14"],
[{y:-0.75,x:2.5},"\n\n\n\n10"],
[{y:-0.75},"\n\n\n\n8",{w:1.5},"\n\n\n\n9",{x:2},"\n\n\n\n19"],
[{y:-0.75,x:3.5},"\n\n\n\n18",{x:1},"\n\n\n\n20"],
[{y:-0.75,x:6.5},"\n\n\n\n21"],
[{y:-0.75,x:2.5},"\n\n\n\n17"],
[{y:-0.75},"\n\n\n\n15",{w:1.5},"\n\n\n\n16",{x:2},"\n\n\n\n26"],
[{y:-0.75,x:3.5},"\n\n\n\n25",{x:1},"\n\n\n\n27"],
[{y:-0.75,x:6.5},"\n\n\n\n28"],
[{y:-0.75,x:2.5},"\n\n\n\n24"],
[{y:-0.75},"\n\n\n\n22",{w:1.5},"\n\n\n\n23",{x:2},"\n\n\n\n33"],
[{y:-0.75,x:3.5},"\n\n\n\n32",{x:1},"\n\n\n\n34"],
[{y:-0.75,x:6.5},"\n\n\n\n35"],
[{y:-0.75,x:2.5},"\n\n\n\n31"],
[{y:-0.75},"\n\n\n\n29",{w:1.5},"\n\n\n\n30"],
[{r:30,rx:8,ry:6.5,y:-0.75,x:-0.75,h:1.5},"\n\n\n\n36",{h:1.5},"\n\n\n\n37"]

[csteamengine]

I've tried setting the rotational center with 0,0 and various other values, but that doesn't seem to help. I've also got the front center label set for the KiCad KBPlacer annotations.

[nooges]

I think the issue is with KLESerial.ts during it's rotation, as it assumes equal vertical and horizontal spacing. I don't quite have the bandwidth at the moment to figure out the math to update the code. Does KBPlacer do it correctly?

As an aside, it looks like the PCB is being designed for a vertical orientation of a 1.5u keycap, and I don't think that exists in the wild other than printing it.

On Fri, Oct 25, 2024 at 11:14 AM Charlie Steenhagen < @.***> wrote:

I've tried setting the rotational center with 0,0 and various other values, but that doesn't seem to help. I've also got the front center label set for the KiCad KBPlacer annotations.

— Reply to this email directly, view it on GitHub https://github.com/keebio/kb-plategen/issues/5#issuecomment-2438091847, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABR3NFIQ4WBIJ6BZDT7G4TZ5JN4NAVCNFSM6AAAAABQTJXXJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGA4TCOBUG4 . You are receiving this because you commented.Message ID: @.***>

[csteamengine]

Hmmm, Ok. I'll see if I can look into it, knowing the file is helpful! KBPlacer puts the switches in the right spot, as long as I use the annotation on the front center legend.

As far as the keycap being 1.5u vertical, I'm just using blank low profile ones so it shouldn't matter 🤷

[nooges]

The stem will be 90 degrees the wrong way though.

On Fri, Oct 25, 2024 at 1:01 PM Charlie Steenhagen @.***> wrote:

Hmmm, Ok. I'll see if I can look into it, knowing the file is helpful! KBPlacer puts the switches in the right spot, as long as I use the annotation on the front center legend.

As far as the keycap being 1.5u vertical, I'm just using blank low profile ones so it shouldn't matter 🤷

— Reply to this email directly, view it on GitHub https://github.com/keebio/kb-plategen/issues/5#issuecomment-2438345354, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABR3NHUKH7G3CO4MQ7YTFTZ5J2M7AVCNFSM6AAAAABQTJXXJCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGM2DKMZVGQ . You are receiving this because you commented.Message ID: @.***>

[csteamengine]

Oh I see what you're saying. I was thinking of MX switches. I'll just rotate the switch itself in the PCB then 👍 Thanks for the head up though

[csteamengine]

It seems to be an issue with the point coordinate calculation in KeyCutouts.ts, but I can't for the life of me figure out what the proper coordinates prior or post rotation should be 😩