keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.94k stars 215 forks source link

[Request] Add missing Jetbrains applications #102

Open aotsishd opened 7 years ago

aotsishd commented 7 years ago

All of the JetBrains IDEs icons remain unchanged (both local and global shortcuts), as seen in the photo.

screenshot from 2017-02-05 19-45-07

Also, Gogland, Rider and JetBrains Toolbox seem to be missings icons.

ghost commented 7 years ago

It doesn't work for Netbeans, or BlueJ either.

Are you sure there are implementations for those icons actually in this repository, I have had a look but I might be looking in the wrong place.

If not, just go and have a look at the .desktop configuration file for the application in /usr/share/applications or ~/.local/share/applications and see where the icon path points to?

I don't know about IntelliJ, as their icon is pretty decent anyway, but Netbeans and BlueJ could really do with an icon, if there isn't one already

keeferrourke commented 7 years ago

There are two possibilities here:

I have no way of knowing which is actually the problem, so please do a bit of investigating on your local machines and report back.

aotsishd commented 7 years ago

Alright so I checked and yes, icons happen to be hardcoded. IntelliJ IDEA for example is located in /usr/local/share/applications and icon points to /home/aotsishd/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/163.12024.16/bin/idea.png. Same goes for the other IDEs, all of them point to similar paths depending on the program version. screenshot from 2017-02-06 12-22-23 screenshot from 2017-02-06 12-21-27

I was able to fix the global shortcut just by changing the path. However, the following JetBrains applications do not have icons.

Should I report them separately?

keeferrourke commented 7 years ago

Adding them here is fine! I need the icon name specified in the desktop file (regardless of the path) and a reference for what the original looks like.

aotsishd commented 7 years ago
Application name Icon name Icon
JetBrains Toolbox toolbox image
MPS .icon image
Rider .icon image
Gogland .icon image

Icons don't seem to carry a name as all of the paths point to their IDE/version subfolders apart from the toolbox.

keeferrourke commented 7 years ago

Can I get the full paths for the Icon entries in the desktop files then? That way I can at least given the icons meaningful names.

aotsishd commented 7 years ago
Application name Icon path Missing icon?
CLion /home/aotsishd/.local/share/JetBrains/Toolbox/apps/CLion/ch-0/163.10154.43/.icon.svg
DataGrip /home/aotsishd/.local/share/JetBrains/Toolbox/apps/datagrip/ch-0/163.12455.1/.icon.svg
Gogland /home/aotsishd/.local/share/JetBrains/Toolbox/apps/Gogland/ch-0/163.12024.27/.icon.svg Yes
IntelliJ IDEA Ultimate /home/aotsishd/.local/share/JetBrains/Toolbox/apps/IDEA-U/ch-0/163.12024.16/.icon.svg
MPS /home/aotsishd/.local/share/JetBrains/Toolbox/apps/MPS/ch-0/162.2189/.icon.svg Yes
PhpStorm /home/aotsishd/.local/share/JetBrains/Toolbox/apps/PhpStorm/ch-0/163.10504.2/.icon.svg
PyCharm Professional /home/aotsishd/.local/share/JetBrains/Toolbox/apps/PyCharm-P/ch-0/163.10154.50/.icon.svg
Rider /home/aotsishd/.local/share/JetBrains/Toolbox/apps/Rider/ch-0/163.12057/.icon.svg Yes
RubyMine /home/aotsishd/.local/share/JetBrains/Toolbox/apps/RubyMine/ch-0/163.9166.34/.icon.svg
WebStorm /home/aotsishd/.local/share/JetBrains/Toolbox/apps/WebStorm/ch-0/163.12024.17/.icon.svg
JetBrains Toolbox /home/aotsishd/.local/share/JetBrains/Toolbox/toolbox.svg Yes

I'm writing all of the IDEs icon paths because I discovered something really annoying while testing: Toolbox will recreate all IDEs entries regardless of any previous modification (same happens if they are deleted) every time it starts, thus rendering any modification to local shortcuts pointless (a global shortcut made through an IDE itself does not get modified, but you end up with duplicated entries for every IDE since Toolbox will just recreate the local entry). Looks like the only way to "set" the icons is by actually replacing the original ones.

keeferrourke commented 7 years ago

@aotsishd that's really annoying... I wish corporate software would obey desktop standards :^)

Here's what I'll do, I'll put a notice in the README about these stupid icons, and add the missing ones named according to what I think they should be called.

To-do:

zencubic commented 6 years ago

@keeferrourke @aotsishd I think Gogland is now called simply Goland so you may edit the name in your posts :wink: