search

keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.95k stars 216 forks source link

[Bug] System applications icon not displayed in KDE menu #104

Closed kun-zhou closed 7 years ago

kun-zhou commented 7 years ago

In KDE Plasma 5.8, the menu directory System has a blank icon. I have experimented with it a bit. The correct directory entry for this menu directory is /usr/share/desktop-directories/kf5-system.directory. In the .directory file, it writes Icon=applications-system. Now, this icon is clearly present in /usr/share/icons/la-capitaine-icon-theme/apps/scalable. I think the fact that it is a symlink is not the cause of the issue. The issue seems to be the name.

  1. If I change it to an icon name that is nowhere to be found, say icon_non_exist, the icon for the menu directory will turn to the default kde's icon not found icon.

  2. If I change it to another icon name, meanin let Icon=firefox in the .directory file, the menu directory shows up as firefox.

  3. If I change the name of the icon in the theme icon folder to another, say sys_icon and let Icon=sys_icon in the .directory, the icon shows up properly.

I am not sure why this is happening because if I change my icon theme to breeze, the menu directory's icon shows up correctly. To clarify, by menu directory, I mean the directory you see when you clock the KDE application launcher widget, usually at the left down corner of one's screen, click on Applications, and you see all the different menu directories such as Multimedia, Games, Office, etc.

keeferrourke commented 7 years ago

Can you post a screenshot of the issue?

...It's possible applications-system or indeed applications-* icons in La Capitaine are corrupt under KDE's SVG rendering engine — this has been an issue for some icons in the past. If this is the case, I'll redesign them.

kun-zhou commented 7 years ago

No problem. I have attached a screenshot. I would also like to clarify the following: If I change the file name of the icon, (not the icon itself, just the name in the scalable folder), and change the corresponding .directory entry in the desktop-directories folder to update the icon it is mapping to, the icon will show up properly.

screenshot_20170206_202125

keeferrourke commented 7 years ago

@kun-zhou I'll take a look, but I won't be able to address this issue for at least a week. Midterms have snuck up on me again, and they're back with a vengeance.

kun-zhou commented 7 years ago

@keeferrourke Haha, no worries. Thanks.

demoy commented 7 years ago

System menu icons visible after recents commits - screenshot_20170214_124832

screenshot_20170214_124921

kun-zhou commented 7 years ago

Haha, thanks! I updated my icons from the git repo. Just wondering what is causing this issue? There are a couple of action button icons in KWrite that is experiencing the same issue. They are blank and the breeze fallback does not kick in. I would love to contribute if that's okay :)

demoy commented 7 years ago

Which Kwrite icons? If they still dont appear post a screenshot in issue 106, and I'l try to find it.

EDIT: the answer to your question is also at issue 106 EDIT2: you don't need permission to help, just find a issue you feel comfortable with. Or if you know css [which I don't] create some icons for your favorite applications.

keeferrourke commented 7 years ago

@demoy aside from the inconsistent look of the application icons in your screenshot, looks good. I'll try to fix the design of those icons later. Gonna close this issue, as it seems to have mostly merged with #106.

keeferrourke commented 7 years ago

@kun-zhou

I would love to contribute if that's okay :)

Absolutely welcome! Any and all contributions will always be considered :)

@demoy Though you didn't mention it, I've opened another issue regarding the inconsistent look of the application categories icons. See #107.