search

keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.94k stars 215 forks source link

[Bug] Missing save and setting icons in KDE menu #105

Closed lucazade closed 7 years ago

lucazade commented 7 years ago

There are no more save, save as and settings icons in menus. Attached Kate screenshot with missing icons in red circles! screenshot_20170211_100613

keeferrourke commented 7 years ago

Yikes! Do you know have any idea which commit broke them? What the file names should be?

lucazade commented 7 years ago

No idea about filenames and which commit broke them. If you need I can try some old release.

keeferrourke commented 7 years ago

@lucazade was it a recent pull? I honestly don't have time to tackle this issue right away; it might be a few weeks before I can take a proper look.

demoy commented 7 years ago

I went through the stable releases, la-capitaine-icon-theme-0.3.2 is the last version with functioning save/save-as icons. Strictly speaking icons are not missing, example document-save is in the same place in version 0.3.2 and lastest commit [and that is actions\22x22 folder].

I replace the document-save icon with the document-save-symbolic [both from latest commit, see below] and the save icons show up screenshot_20170213_140551

Permissions are fine, so my conclusion is something is off in the files themselves. Heres what firefox output: screenshot_20170213_141711

Remove the needs clarification label from this issue if this is satisfactory.

Here beneath for completeness sake here is la-capitaine-icon-theme/actions/22x22-light/document-revert.svg below working in firefox as the control case to document save. screenshot_20170213_141929

keeferrourke commented 7 years ago

Should be fixed now!

demoy commented 7 years ago

Fixed seen working below in Kate [application used by the riginal poster] screenshot_20170213_153631

Now to uninstall Kate, ◔ᴗ◔.

lucazade commented 7 years ago

thanks for the works guys! save icons now are ok.. settings icon instead is still missing here :(

demoy commented 7 years ago

Sorry About that I will run through to find it. Edit: I'm not share where to look so I began compiling a list of icons with this issue hopely the one you care about will be on it and get fixed. List of broken emblems

keeferrourke commented 7 years ago

The settings icons are likely likely to 22x22-*/document-properties.svg; an icon that is broken as stated in #106. Will close this issue again when I fix it :)

keeferrourke commented 7 years ago

@lucazade pull the latest commits and let me know if the settings icon has been fixed :)

lucazade commented 7 years ago

@keeferrourke fixed now! thanks a lot :)