keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.93k stars 216 forks source link

[Request] Increase pantheon support #241

Open btd1337 opened 6 years ago

btd1337 commented 6 years ago

Please increase support in the pantheon enviroment. Normalize the size of the Wingpanel icons.

Be inspired by this modification of the Papirus icon theme (ePapirus), created especially for works on pantheon.

https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/master/ePapirus

La Capitaine style: screenshot from 2017-09-19 14-24-15

ePapirus style: screenshot from 2017-09-19 14-23-54

keeferrourke commented 6 years ago

The only issue I see with the screenshot above is that your red-shift status icon is dark. You should be able to fix this by running the config script and choosing to use the dark panel variant.

Unless I'm seriously missing something here...?

btd1337 commented 6 years ago

The Pantheon needs the size of the icons to be 22px, like the dropbox and layout keyboard icons, to properly align the bar.

But others La Capitaine wingpanel indicator icons are 24px in size.

It's necessary to fix this to correct its alignment on the Pantheon.

fix la-capitaine

btd1337 commented 6 years ago

Default pantheon size: All icons in 22px screenshot from 2017-09-19 16-49-10

La Capitaine Style: Dropbox, Redshift and keyboard layout: 22px, but other wingpanel icons in 24px screenshot from 2017-09-19 16-48-50

keeferrourke commented 6 years ago

@btd1337 next time, please include this information in the original issue report, and use cropped screenshots that better demonstrate the problem. This saves both you and I time.

Which icons are incorrectly sized under pantheon? Can you provide a list? Are there pantheon docs you can point me to that specify what the DE expects? Unfortunately I don't have a lot of time to dedicate to this project at the moment, so being super explicit is the best way to ensure this issue is closed in a timely manner.

btd1337 commented 6 years ago

Right.

To learn more about the elementaryOS's iconography: https://elementary.io/docs/human-interface-guidelines#composition

Just correcting an information:

The size of the panel icons is 24 px but it's necessary to correct the measures.

Use this as a basis

screenshot from 2017-09-20 00-58-49

screenshot from 2017-09-20 00-58-05

As I said, use this theme as a base: https://github.com/PapirusDevelopmentTeam/papirus-icon-theme/tree/master/ePapirus/24x24/panel

I believe the icons in this folder need to have the alignment corrected: La Capitaine/panel/24/

More urgently: Sound, Network, Bluetooth, Battery, Notification indicators and system-devices-panel.

More information is available in https://elementary.io/docs/human-interface-guidelines#shadows

surajmandalcell commented 6 years ago

Any updates on this?

surajmandalcell commented 6 years ago

In eos you can temporarily use cd ~/.icons/la-capitaine-icon-theme && cp -r /usr/share/icons/elementary/status/24/* panel/24/ to use the default elementary stylesheet icons in wingpanel.

Source : https://github.com/surajmandalcell/elementary-x/blob/master/install_fixed_icons.sh