search

keeferrourke / la-capitaine-icon-theme

La Capitaine is an icon pack designed to integrate with most desktop environments. The set of icons takes inspiration from the latest iterations of macOS and Google's Material Design.
https://krourke.org/projects/art/la-capitaine-icon-theme
Other
1.94k stars 215 forks source link

[REQUEST] - XFCE system try icons #52

Closed rtalexk closed 7 years ago

rtalexk commented 7 years ago

I love Le Capitaine icon theme, I use it on all my Linux distros, I tend to use Plasma 5 and Xfce but always i have the same problem: system tray.

I tried to configure by myself, but symbolic links already exists. I'm think hicolor icons are ugly.

I don't know how Xfce manage icons, maybe something like #35 could help.

captura de pantalla_2016-11-06_10-05-41

juanlatorre commented 7 years ago

Indeed, i request this too, this icons are perfect !

keeferrourke commented 7 years ago

Dammit. I thought I fixed this. I'll look into it -- but I'm in the middle of my second round of midterms (they never end!!)

if anyone else has a chance to look at this, I'd be more than happy for the help :)

juanlatorre commented 7 years ago

Hey, i've look into this, for some reason my icons work fine after deleting the "xfpm-primary*" icons from Hicolor theme, the icons from La Capitaine worked perfectly (i edited some of them to match my dark panel).

Inside the XFCE-Power-Managament plugin for XFCE4-Panel in /usr/share/xfce4/panel/plugins/power-manager-plugin.desktop, there is a String that say:

Icon=xfpm-primary-100-charging

screenshot_2016-11-08_09-59-39

I believe that the XFPM module isn't finding the icon on La Capitaine pack and that's why is using de Hicolor icons, maybe the icons need the same name (I renamed my icons and now work, but i don't know if is because of the rename).

Sorry for my bad english, and i hope that this can be helpful for you.

Edit: I believe that the icons for Battery Status are XFPM-Battery and not XFCE-Battery, because one uses the XFCE Power Management plugin and the other uses the Battery Tray Status (or something like that)

keeferrourke commented 7 years ago

hmm okay, so I think the battery icons XFCE is looking for are called xfpm-primary-* and not xfpm-battery-*.

I can get an update pushed soon, if you think I've ignored it - just ping me.

Cheers.

juanlatorre commented 7 years ago

Thanks, i'll be in touch !

ryzokuken commented 7 years ago

What's the status on this? I am facing the same problem (all icons are rendered perfectly, but the power icons looks ugly as hell) this issue does not occur when I use Numix or Paper (if it helps)

keeferrourke commented 7 years ago

Hi @ryzokuken I saw the issue you opened. This has fallen by the wayside for a while because I've been busy. I'll try to take a look this week, but I'm super busy with school assignments right now. As mentioned before, it's likely that I just need to add symlinks with names of the pattern xfpm-primary-*. I don't currently have XFCE set up though, so I cannot test this right now.

ryzokuken commented 7 years ago

@keeferrourke If it involves only symlinking, I could submit a PR if you could give me a little more detail about what to do (if you are too busy to do it). Also, I could help you test it if you'd like. Keep up the good work.

keeferrourke commented 7 years ago

I think every xfpm-battery-* icon needs to be symlinked to an xfpm-primary-* with the same suffix. For example:

A PR + testing would be welcome, thanks!

keeferrourke commented 7 years ago

Should be fixed in the latest commits. See issue #119.